From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96E42C10DCE for ; Wed, 18 Mar 2020 03:58:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 75E8920753 for ; Wed, 18 Mar 2020 03:58:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727124AbgCRD6o (ORCPT ); Tue, 17 Mar 2020 23:58:44 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:35420 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726506AbgCRD6o (ORCPT ); Tue, 17 Mar 2020 23:58:44 -0400 Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id EF19413EC66BB; Tue, 17 Mar 2020 20:58:43 -0700 (PDT) Date: Tue, 17 Mar 2020 20:58:43 -0700 (PDT) Message-Id: <20200317.205843.1649558746994587425.davem@davemloft.net> To: hkallweit1@gmail.com Cc: andrew@lunn.ch, f.fainelli@gmail.com, linux@armlinux.org.uk, netdev@vger.kernel.org Subject: Re: [PATCH net-next 0/2] net: phy: improve phy_driver callback handle_interrupt From: David Miller In-Reply-To: <49afbad9-317a-3eff-3692-441fae3c4f49@gmail.com> References: <49afbad9-317a-3eff-3692-441fae3c4f49@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 17 Mar 2020 20:58:44 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Heiner Kallweit Date: Mon, 16 Mar 2020 22:31:48 +0100 > did_interrupt() clears the interrupt, therefore handle_interrupt() can > not check which event triggered the interrupt. To overcome this > constraint and allow more flexibility for customer interrupt handlers, > let's decouple handle_interrupt() from parts of the phylib interrupt > handling. Custom interrupt handlers now have to implement the > did_interrupt() functionality in handle_interrupt() if needed. > > Fortunately we have just one custom interrupt handler so far (in the > mscc PHY driver), convert it to the changed API and make use of the > benefits. Series applied, thanks Heiner.