From: David Miller <davem@davemloft.net>
To: opendmb@gmail.com
Cc: f.fainelli@gmail.com, bcm-kernel-feedback-list@broadcom.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 0/2] net: bcmgenet: revisit MAC reset
Date: Tue, 17 Mar 2020 21:02:20 -0700 (PDT) [thread overview]
Message-ID: <20200317.210220.1278270199388080239.davem@davemloft.net> (raw)
In-Reply-To: <1584395096-41674-1-git-send-email-opendmb@gmail.com>
From: Doug Berger <opendmb@gmail.com>
Date: Mon, 16 Mar 2020 14:44:54 -0700
> Commit 3a55402c9387 ("net: bcmgenet: use RGMII loopback for MAC
> reset") was intended to resolve issues with reseting the UniMAC
> core within the GENET block by providing better control over the
> clocks used by the UniMAC core. Unfortunately, it is not
> compatible with all of the supported system configurations so an
> alternative method must be applied.
>
> This commit set provides such an alternative. The first commit
> reverts the previous change and the second commit provides the
> alternative reset sequence that addresses the concerns observed
> with the previous implementation.
>
> This replacement implementation should be applied to the stable
> branches wherever commit 3a55402c9387 ("net: bcmgenet: use RGMII
> loopback for MAC reset") has been applied.
>
> Unfortunately, reverting that commit may conflict with some
> restructuring changes introduced by commit 4f8d81b77e66 ("net:
> bcmgenet: Refactor register access in bcmgenet_mii_config").
> The first commit in this set has been manually edited to
> resolve the conflict on net/master. I would be happy to help
> stable maintainers with resolving any such conflicts if they
> occur. However, I do not expect that commit to have been
> backported to stable branch so hopefully the revert can be
> applied cleanly.
Series applied and queued up for -stable, thank you.
prev parent reply other threads:[~2020-03-18 4:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-16 21:44 [PATCH net 0/2] net: bcmgenet: revisit MAC reset Doug Berger
2020-03-16 21:44 ` [PATCH net 1/2] Revert "net: bcmgenet: use RGMII loopback for MAC reset" Doug Berger
2020-03-17 2:21 ` Florian Fainelli
2020-03-17 19:43 ` Doug Berger
2020-03-16 21:44 ` [PATCH net 2/2] net: bcmgenet: keep MAC in reset until PHY is up Doug Berger
2020-03-17 2:22 ` Florian Fainelli
2020-03-18 4:02 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200317.210220.1278270199388080239.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=opendmb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).