From: David Miller <davem@davemloft.net>
To: nikolay@cumulusnetworks.com
Cc: netdev@vger.kernel.org, roopa@cumulusnetworks.com,
bridge@lists.linux-foundation.org
Subject: Re: [PATCH net-next 0/4] net: bridge: vlan options: add support for tunnel mapping
Date: Tue, 17 Mar 2020 22:47:32 -0700 (PDT) [thread overview]
Message-ID: <20200317.224732.583644832239870673.davem@davemloft.net> (raw)
In-Reply-To: <20200317120836.1765164-1-nikolay@cumulusnetworks.com>
From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Date: Tue, 17 Mar 2020 14:08:32 +0200
> In order to bring the new vlan API on par with the old one and be able
> to completely migrate to the new one we need to support vlan tunnel mapping
> and statistics. This patch-set takes care of the former by making it a
> vlan option. There are two notable issues to deal with:
> - vlan range to tunnel range mapping
> * The tunnel ids are globally unique for the vlan code and a vlan can
> be mapped to one tunnel, so the old API took care of ranges by
> taking the starting tunnel id value and incrementally mapping
> vlan id(i) -> tunnel id(i). This set takes the same approach and
> uses one new attribute - BRIDGE_VLANDB_ENTRY_TUNNEL_ID. If used
> with a vlan range then it's the starting tunnel id to map.
>
> - tunnel mapping removal
> * Since there are no reserved/special tunnel ids defined, we can't
> encode mapping removal within the new attribute, in order to be
> able to remove a mapping we add a vlan flag which makes the new
> tunnel option remove the mapping
>
> The rest is pretty straight-forward, in fact we directly re-use the old
> code for manipulating tunnels by just mapping the command (set/del). In
> order to be able to keep detecting vlan ranges we check that the current
> vlan has a tunnel and it's extending the current vlan range end's tunnel
> id.
Looks good, series applied, thank you.
prev parent reply other threads:[~2020-03-18 8:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 12:08 [PATCH net-next 0/4] net: bridge: vlan options: add support for tunnel mapping Nikolay Aleksandrov
2020-03-17 12:08 ` [PATCH net-next 1/4] net: bridge: vlan options: rename br_vlan_opts_eq to br_vlan_opts_eq_range Nikolay Aleksandrov
2020-03-17 12:08 ` [PATCH net-next 2/4] net: bridge: vlan tunnel: constify bridge and port arguments Nikolay Aleksandrov
2020-03-17 12:08 ` [PATCH net-next 3/4] net: bridge: vlan options: add support for tunnel id dumping Nikolay Aleksandrov
2020-03-17 12:08 ` [PATCH net-next 4/4] net: bridge: vlan options: add support for tunnel mapping set/del Nikolay Aleksandrov
2020-03-18 5:47 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200317.224732.583644832239870673.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bridge@lists.linux-foundation.org \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).