netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: daniel@iogearbox.net
Cc: netdev@vger.kernel.org, pablo@netfilter.org, ast@kernel.org
Subject: Re: [PATCH net-next] netfilter: revert introduction of egress hook
Date: Wed, 18 Mar 2020 18:45:31 -0700 (PDT)	[thread overview]
Message-ID: <20200318.184531.2286126098336198373.davem@davemloft.net> (raw)
In-Reply-To: <bbdee6355234e730ef686f9321bd072bcf4bb232.1584523237.git.daniel@iogearbox.net>

From: Daniel Borkmann <daniel@iogearbox.net>
Date: Wed, 18 Mar 2020 10:33:22 +0100

> This reverts the following commits:
> 
>   8537f78647c0 ("netfilter: Introduce egress hook")
>   5418d3881e1f ("netfilter: Generalize ingress hook")
>   b030f194aed2 ("netfilter: Rename ingress hook include file")
> 
> From the discussion in [0], the author's main motivation to add a hook
> in fast path is for an out of tree kernel module, which is a red flag
> to begin with. Other mentioned potential use cases like NAT{64,46}
> is on future extensions w/o concrete code in the tree yet. Revert as
> suggested [1] given the weak justification to add more hooks to critical
> fast-path.
> 
>   [0] https://lore.kernel.org/netdev/cover.1583927267.git.lukas@wunner.de/
>   [1] https://lore.kernel.org/netdev/20200318.011152.72770718915606186.davem@davemloft.net/
> 
> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>

Applied, this definitely needs more discussion.

Thanks Daniel.

      parent reply	other threads:[~2020-03-19  1:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-18  9:33 [PATCH net-next] netfilter: revert introduction of egress hook Daniel Borkmann
2020-03-18  9:36 ` Pablo Neira Ayuso
2020-03-18  9:41   ` Daniel Borkmann
2020-03-18  9:51     ` Pablo Neira Ayuso
2020-03-18 10:02 ` Florian Westphal
2020-03-18 10:50   ` Daniel Borkmann
2020-03-18 12:33     ` Florian Westphal
2020-03-18 14:22       ` Daniel Borkmann
2020-03-19  1:45 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200318.184531.2286126098336198373.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=ast@kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=netdev@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).