From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD38CC10DCE for ; Wed, 18 Mar 2020 09:36:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B977020771 for ; Wed, 18 Mar 2020 09:36:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727550AbgCRJg4 (ORCPT ); Wed, 18 Mar 2020 05:36:56 -0400 Received: from correo.us.es ([193.147.175.20]:33830 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726586AbgCRJg4 (ORCPT ); Wed, 18 Mar 2020 05:36:56 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 0ACEDEBAC6 for ; Wed, 18 Mar 2020 10:36:25 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id EFF66DA3AB for ; Wed, 18 Mar 2020 10:36:24 +0100 (CET) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id E5681DA3A5; Wed, 18 Mar 2020 10:36:24 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id CB3E9DA7B6; Wed, 18 Mar 2020 10:36:20 +0100 (CET) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Wed, 18 Mar 2020 10:36:20 +0100 (CET) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (unknown [90.77.255.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id AF94542EE399; Wed, 18 Mar 2020 10:36:20 +0100 (CET) Date: Wed, 18 Mar 2020 10:36:49 +0100 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Daniel Borkmann Cc: davem@davemloft.net, netdev@vger.kernel.org, Alexei Starovoitov Subject: Re: [PATCH net-next] netfilter: revert introduction of egress hook Message-ID: <20200318093649.sn3hsi7nkd3j34lj@salvia> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Virus-Scanned: ClamAV using ClamSMTP Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Mar 18, 2020 at 10:33:22AM +0100, Daniel Borkmann wrote: > This reverts the following commits: > > 8537f78647c0 ("netfilter: Introduce egress hook") > 5418d3881e1f ("netfilter: Generalize ingress hook") > b030f194aed2 ("netfilter: Rename ingress hook include file") > > From the discussion in [0], the author's main motivation to add a hook > in fast path is for an out of tree kernel module, which is a red flag > to begin with. Other mentioned potential use cases like NAT{64,46} > is on future extensions w/o concrete code in the tree yet. Revert as > suggested [1] given the weak justification to add more hooks to critical > fast-path. > > [0] https://lore.kernel.org/netdev/cover.1583927267.git.lukas@wunner.de/ > [1] https://lore.kernel.org/netdev/20200318.011152.72770718915606186.davem@davemloft.net/ > > Signed-off-by: Daniel Borkmann Nacked-by: Pablo Neira Ayuso Daniel, you must be really worried about achieving your goals if you have to do politics to block stuff.