From: David Miller <davem@davemloft.net>
To: idosch@idosch.org
Cc: netdev@vger.kernel.org, jiri@mellanox.com, mlxsw@mellanox.com,
idosch@mellanox.com
Subject: Re: [PATCH net] mlxsw: pci: Only issue reset when system is ready
Date: Thu, 19 Mar 2020 20:24:12 -0700 (PDT) [thread overview]
Message-ID: <20200319.202412.154737138482561630.davem@davemloft.net> (raw)
In-Reply-To: <20200319112539.1030494-1-idosch@idosch.org>
From: Ido Schimmel <idosch@idosch.org>
Date: Thu, 19 Mar 2020 13:25:39 +0200
> From: Ido Schimmel <idosch@mellanox.com>
>
> During initialization the driver issues a software reset command and
> then waits for the system status to change back to "ready" state.
>
> However, before issuing the reset command the driver does not check that
> the system is actually in "ready" state. On Spectrum-{1,2} systems this
> was always the case as the hardware initialization time is very short.
> On Spectrum-3 systems this is no longer the case. This results in the
> software reset command timing-out and the driver failing to load:
>
> [ 6.347591] mlxsw_spectrum3 0000:06:00.0: Cmd exec timed-out (opcode=40(ACCESS_REG),opcode_mod=0,in_mod=0)
> [ 6.358382] mlxsw_spectrum3 0000:06:00.0: Reg cmd access failed (reg_id=9023(mrsr),type=write)
> [ 6.368028] mlxsw_spectrum3 0000:06:00.0: cannot register bus device
> [ 6.375274] mlxsw_spectrum3: probe of 0000:06:00.0 failed with error -110
>
> Fix this by waiting for the system to become ready both before issuing
> the reset command and afterwards. In case of failure, print the last
> system status to aid in debugging.
>
> Fixes: da382875c616 ("mlxsw: spectrum: Extend to support Spectrum-3 ASIC")
> Signed-off-by: Ido Schimmel <idosch@mellanox.com>
> Reviewed-by: Jiri Pirko <jiri@mellanox.com>
Applied and queued up for -stable.
prev parent reply other threads:[~2020-03-20 3:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-19 11:25 [PATCH net] mlxsw: pci: Only issue reset when system is ready Ido Schimmel
2020-03-20 3:24 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200319.202412.154737138482561630.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=idosch@idosch.org \
--cc=idosch@mellanox.com \
--cc=jiri@mellanox.com \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).