Netdev Archive on lore.kernel.org
 help / color / Atom feed
From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: davem@davemloft.net, netdev@vger.kernel.org
Cc: "Jason A. Donenfeld" <Jason@zx2c4.com>
Subject: [PATCH net 0/5] wireguard fixes for 5.6-rc7
Date: Wed, 18 Mar 2020 18:30:42 -0600
Message-ID: <20200319003047.113501-1-Jason@zx2c4.com> (raw)

Hi Dave,

I originally intended to spend this cycle working on fun optimizations
and architecture for WireGuard for 5.7, but I've been a bit neurotic
about having 5.6 ship without any show stopper bugs. WireGuard has been
stable for a long time now, but that doesn't make me any less nervous
about the real deal in 5.6. To that end, I've been doing code reviews
and having discussions, and we also had a security firm audit the code.
That audit didn't turn up any vulnerabilities, but they did make a good
defense-in-depth suggestion. This series contains:

1) Removal of a duplicated header, from YueHaibing.
2) Testing with 64-bit time in our test suite.
3) Account for skb->protocol==0 due to AF_PACKET sockets, suggested
   by Florian Fainelli.
4) Clean up some code in an unreachable switch/case branch, suggested
   by Florian Fainelli.
5) Better handling of low-order points, discussed with Mathias
   Hall-Andersen.

Thanks,
Jason

Jason A. Donenfeld (4):
  wireguard: selftests: test using new 64-bit time_t
  wireguard: queueing: account for skb->protocol==0
  wireguard: receive: remove dead code from default packet type case
  wireguard: noise: error out precomputed DH during handshake rather
    than config

YueHaibing (1):
  wireguard: selftests: remove duplicated include <sys/types.h>

 drivers/net/wireguard/device.c                |  2 +-
 drivers/net/wireguard/netlink.c               |  8 +--
 drivers/net/wireguard/noise.c                 | 55 ++++++++++---------
 drivers/net/wireguard/noise.h                 | 12 ++--
 drivers/net/wireguard/peer.c                  |  7 +--
 drivers/net/wireguard/queueing.h              |  8 ++-
 drivers/net/wireguard/receive.c               |  7 +--
 tools/testing/selftests/wireguard/netns.sh    |  6 --
 .../testing/selftests/wireguard/qemu/Makefile |  2 +-
 tools/testing/selftests/wireguard/qemu/init.c |  1 -
 .../selftests/wireguard/qemu/kernel.config    |  1 -
 11 files changed, 51 insertions(+), 58 deletions(-)

-- 
2.25.1


             reply index

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-19  0:30 Jason A. Donenfeld [this message]
2020-03-19  0:30 ` [PATCH net 1/5] wireguard: selftests: remove duplicated include <sys/types.h> Jason A. Donenfeld
2020-03-19  0:30 ` [PATCH net 2/5] wireguard: selftests: test using new 64-bit time_t Jason A. Donenfeld
2020-03-19  0:30 ` [PATCH net 3/5] wireguard: queueing: account for skb->protocol==0 Jason A. Donenfeld
2020-03-19  0:30 ` [PATCH net 4/5] wireguard: receive: remove dead code from default packet type case Jason A. Donenfeld
2020-03-19  0:30 ` [PATCH net 5/5] wireguard: noise: error out precomputed DH during handshake rather than config Jason A. Donenfeld
2020-03-19  1:54 ` [PATCH net 0/5] wireguard fixes for 5.6-rc7 David Miller
2020-03-19  2:30   ` Jason A. Donenfeld

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200319003047.113501-1-Jason@zx2c4.com \
    --to=jason@zx2c4.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Netdev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/netdev/0 netdev/git/0.git
	git clone --mirror https://lore.kernel.org/netdev/1 netdev/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 netdev netdev/ https://lore.kernel.org/netdev \
		netdev@vger.kernel.org
	public-inbox-index netdev

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.netdev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git