From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6D16C43332 for ; Thu, 19 Mar 2020 00:30:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8598B20774 for ; Thu, 19 Mar 2020 00:30:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="qSpAdg8q" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727323AbgCSAa4 (ORCPT ); Wed, 18 Mar 2020 20:30:56 -0400 Received: from frisell.zx2c4.com ([192.95.5.64]:39393 "EHLO frisell.zx2c4.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726663AbgCSAaz (ORCPT ); Wed, 18 Mar 2020 20:30:55 -0400 Received: by frisell.zx2c4.com (ZX2C4 Mail Server) with ESMTP id bf45f4c4; Thu, 19 Mar 2020 00:24:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=zx2c4.com; h=from:to:cc :subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; s=mail; bh=LFpBGwNRgFHGa/caMU+O/krcQ xk=; b=qSpAdg8qiGQBTilxRdDjFwwC+GB/8pp90ogTxiZAQFzon4fvMQldJyXEI r5xIiUoK2hLtHrFwqG3op2AlmY9eGqudkls4/WTmQgu4p+0wrDNYXE5n+KmcOuQR tsMGDDK8r8MblI1KqMAzj8Kf9fQlvg42ZxcPD6UjhMkl17NIAy4BufWwdlBehhe+ fABFVYtF03pTHT9rsjp3cELl5XbvskVBzav0fIbi/dr9WM8JAJZ1Xo4faYecWnuq VDUyIG56apbmVZ2DY7yvgh2F9+3VnZRC2tTVwuzfaQ2DkrsPt0byaLufLoUJM+O9 OphFZs0a2CaC8dnM72fxglNq2g39g== Received: by frisell.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 764842ee (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Thu, 19 Mar 2020 00:24:28 +0000 (UTC) From: "Jason A. Donenfeld" To: davem@davemloft.net, netdev@vger.kernel.org Cc: "Jason A. Donenfeld" Subject: [PATCH net 4/5] wireguard: receive: remove dead code from default packet type case Date: Wed, 18 Mar 2020 18:30:46 -0600 Message-Id: <20200319003047.113501-5-Jason@zx2c4.com> In-Reply-To: <20200319003047.113501-1-Jason@zx2c4.com> References: <20200319003047.113501-1-Jason@zx2c4.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The situation in which we wind up hitting the default case here indicates a major bug in earlier parsing code. It is not a usual thing that should ever happen, which means a "friendly" message for it doesn't make sense. Rather, replace this with a WARN_ON, just like we do earlier in the file for a similar situation, so that somebody sends us a bug report and we can fix it. Reported-by: Fabian Freyer Signed-off-by: Jason A. Donenfeld --- drivers/net/wireguard/receive.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/wireguard/receive.c b/drivers/net/wireguard/receive.c index 243ed7172dd2..da3b782ab7d3 100644 --- a/drivers/net/wireguard/receive.c +++ b/drivers/net/wireguard/receive.c @@ -587,8 +587,7 @@ void wg_packet_receive(struct wg_device *wg, struct sk_buff *skb) wg_packet_consume_data(wg, skb); break; default: - net_dbg_skb_ratelimited("%s: Invalid packet from %pISpfsc\n", - wg->dev->name, skb); + WARN(1, "Non-exhaustive parsing of packet header lead to unknown packet type!\n"); goto err; } return; -- 2.25.1