From: Greg KH <greg@kroah.com>
To: Doug Anderson <dianders@chromium.org>
Cc: "stable@vger.kernel.org" <stable@vger.kernel.org>,
Wen Gong <wgong@codeaurora.org>, netdev <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
ath11k@lists.infradead.org, David Miller <davem@davemloft.net>
Subject: Re: [PATCH v2] net: qrtr: fix len of skb_put_padto in qrtr_node_enqueue
Date: Thu, 19 Mar 2020 08:46:34 +0100 [thread overview]
Message-ID: <20200319074634.GA3421780@kroah.com> (raw)
In-Reply-To: <CAD=FV=XXPACnPt=5=7gH3L6DufZ4tLSPTN-AtTAmvi5KAJuP6A@mail.gmail.com>
On Tue, Mar 17, 2020 at 08:45:09AM -0700, Doug Anderson wrote:
> Hi,
>
> On Tue, Mar 17, 2020 at 3:26 AM Greg KH <greg@kroah.com> wrote:
> >
> > On Tue, Feb 25, 2020 at 02:52:24PM -0800, Doug Anderson wrote:
> > > Hi,
> > >
> > >
> > > On Sun, Jan 5, 2020 at 2:47 PM David Miller <davem@davemloft.net> wrote:
> > > >
> > > > From: Wen Gong <wgong@codeaurora.org>
> > > > Date: Fri, 3 Jan 2020 12:50:16 +0800
> > > >
> > > > > The len used for skb_put_padto is wrong, it need to add len of hdr.
> > > >
> > > > Thanks, applied.
> > >
> > > I noticed this patch is in mainline now as:
> > >
> > > ce57785bf91b net: qrtr: fix len of skb_put_padto in qrtr_node_enqueue
> > >
> > > Though I'm not an expert on the code, it feels like a stable candidate
> > > unless someone objects.
> >
> > Stable candidate for what tree(s)?
>
> I noticed that it was lacking and applied cleanly on 5.4. As of
> 5.4.25 it's still not stable there. I only noticed it because I was
> comparing all the patches in mainline in "net/qrtr" with what we had
> in our tree and stumbled upon this one.
>
> Looking at it a little more carefully, I guess you could say:
>
> Fixes: e7044482c8ac ("net: qrtr: Pass source and destination to
> enqueue functions")
>
> ...though it will be trickier to apply past commit 194ccc88297a ("net:
> qrtr: Support decoding incoming v2 packets") just because the math
> changed.
Given that both of those commits showed up in 4.15, it doesn't matter
much :)
I've queued this up for 5.4.y and 4.19.y now, thanks.
greg k-h
prev parent reply other threads:[~2020-03-19 7:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-03 4:50 [PATCH v2] net: qrtr: fix len of skb_put_padto in qrtr_node_enqueue Wen Gong
2020-01-05 22:47 ` David Miller
2020-01-06 2:04 ` Wen Gong
2020-02-25 22:52 ` Doug Anderson
2020-02-27 4:28 ` David Miller
2020-03-17 10:26 ` Greg KH
2020-03-17 15:45 ` Doug Anderson
2020-03-19 7:46 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200319074634.GA3421780@kroah.com \
--to=greg@kroah.com \
--cc=ath11k@lists.infradead.org \
--cc=davem@davemloft.net \
--cc=dianders@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=wgong@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).