From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C948CC4332B for ; Thu, 19 Mar 2020 08:58:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9AE9420724 for ; Thu, 19 Mar 2020 08:58:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="TH+EMnSq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726840AbgCSI60 (ORCPT ); Thu, 19 Mar 2020 04:58:26 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:44632 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725767AbgCSI60 (ORCPT ); Thu, 19 Mar 2020 04:58:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=3qTNVfTalmQw4j9NwfoM927J2Yu1TVj9lFggc1wxXrM=; b=TH+EMnSqYlryYc/9Modbn0ujuk uQ3fMqCReDQHzRHrsLYK3/47CJnkiE8xAPUghz+XlvkiIt2Nd2vGZjxEKJvbVNa4XkXu8Je93DKPA jFc34UPG5EBfpluUVN2Vz1hKFrxRYI/2mIhz+PsEZek5ER/bFa7vBr2imsQNVvTE3Oe8=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1jEr0G-0005Py-6I; Thu, 19 Mar 2020 09:58:12 +0100 Date: Thu, 19 Mar 2020 09:58:12 +0100 From: Andrew Lunn To: Marek Behun Cc: Chris Packham , "netdev@vger.kernel.org" Subject: Re: [PATCH net-next] net: mvmdio: fix driver probe on missing irq Message-ID: <20200319085812.GA20761@lunn.ch> References: <20200319012940.14490-1-marek.behun@nic.cz> <20200319052119.4e694c8b@nic.cz> <20200319053659.4da19ae0@nic.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200319053659.4da19ae0@nic.cz> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Mar 19, 2020 at 05:36:59AM +0100, Marek Behun wrote: > On Thu, 19 Mar 2020 04:27:56 +0000 > Chris Packham wrote: > > > On Thu, 2020-03-19 at 05:21 +0100, Marek Behun wrote: > > > On Thu, 19 Mar 2020 02:00:57 +0000 > > > Chris Packham wrote: > > > > > > > Hi Marek, > > > > > > > > On Thu, 2020-03-19 at 02:29 +0100, Marek Behún wrote: > > > > > Commit e1f550dc44a4 made the use of platform_get_irq_optional, which can > > > > > return -ENXIO when interrupt is missing. Handle this as non-error, > > > > > otherwise the driver won't probe. > > > > > > > > This has already been fixed in net/master by reverting e1f550dc44a4 and > > > > replacing it with fa2632f74e57bbc869c8ad37751a11b6147a3acc. > > > > > > :( It isn't in net-next. I've spent like an hour debugging it :-D > > > > I can only offer my humble apologies and promise to do better next > > time. I did test the first minimally correct change, but clearly > > stuffed up on v2. > > That's ok, but this should be also in net-next as well. Has Dave > forgotten to apply it there, or is there some other plan? It probably went into net. It then takes around a week before net is merged into net-next. Andrew