From: Jakub Kicinski <kuba@kernel.org>
To: Ido Schimmel <idosch@idosch.org>
Cc: netdev@vger.kernel.org, davem@davemloft.net, jiri@mellanox.com,
jhs@mojatatu.com, xiyou.wangcong@gmail.com, petrm@mellanox.com,
mlxsw@mellanox.com, Ido Schimmel <idosch@mellanox.com>
Subject: Re: [PATCH net-next 0/5] mlxsw: Offload TC action skbedit priority
Date: Thu, 19 Mar 2020 15:24:12 -0700 [thread overview]
Message-ID: <20200319152412.088acba3@kicinski-fedora-PC1C0HJN> (raw)
In-Reply-To: <20200319134724.1036942-1-idosch@idosch.org>
On Thu, 19 Mar 2020 15:47:19 +0200 Ido Schimmel wrote:
> From: Ido Schimmel <idosch@mellanox.com>
>
> Petr says:
>
> The TC action "skbedit priority P" has the effect of assigning skbprio of P
> to SKBs that it's applied on. In HW datapath of a switch, the corresponding
> action is assignment of internal switch priority. Spectrum switches allow
> setting of packet priority based on an ACL action, which is good match for
> the skbedit priority gadget. This patchset therefore implements offloading
> of this action to the Spectrum ACL engine.
>
> After a bit of refactoring in patch #1, patch #2 extends the skbedit action
> to support offloading of "priority" subcommand.
>
> On mlxsw side, in patch #3, the QOS_ACTION flexible action is added, with
> fields necessary for priority adjustment. In patch #4, "skbedit priority"
> is connected to that action.
>
> Patch #5 implements a new forwarding selftest, suitable for both SW- and
> HW-datapath testing.
FWIW:
Reviewed-by: Jakub Kicinski <kuba@kernel.org>
next prev parent reply other threads:[~2020-03-19 22:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-19 13:47 [PATCH net-next 0/5] mlxsw: Offload TC action skbedit priority Ido Schimmel
2020-03-19 13:47 ` [PATCH net-next 1/5] net: tc_skbedit: Factor a helper out of is_tcf_skbedit_{mark, ptype}() Ido Schimmel
2020-03-19 13:47 ` [PATCH net-next 2/5] net: tc_skbedit: Make the skbedit priority offloadable Ido Schimmel
2020-03-19 13:47 ` [PATCH net-next 3/5] mlxsw: core: Add QOS_ACTION Ido Schimmel
2020-03-19 13:47 ` [PATCH net-next 4/5] mlxsw: spectrum_flower: Offload FLOW_ACTION_PRIORITY Ido Schimmel
2020-03-19 13:47 ` [PATCH net-next 5/5] selftests: forwarding: Add an skbedit priority selftest Ido Schimmel
2020-03-19 22:24 ` Jakub Kicinski [this message]
2020-03-20 4:09 ` [PATCH net-next 0/5] mlxsw: Offload TC action skbedit priority David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200319152412.088acba3@kicinski-fedora-PC1C0HJN \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=idosch@idosch.org \
--cc=idosch@mellanox.com \
--cc=jhs@mojatatu.com \
--cc=jiri@mellanox.com \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=petrm@mellanox.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).