From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 099E3C4332B for ; Fri, 20 Mar 2020 17:14:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C348A20739 for ; Fri, 20 Mar 2020 17:14:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584724494; bh=wsQ9ZIqce6T8WDfwtxBoI75BeEpfI73B6LCZCTrvm/w=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=udaRwBPrQEPUdQ3eUBzfSpROMszNzpdURGgO2re7v7zwsvByx+SJ8LDuJvHJy9PV3 //5yY1KP80kZ79CLeXY8ZYMjtkUnaru2zONY56Ce2VYkEm2A3GgC6WSaLqAkJ1V+wZ Qu2BlHAjMCrRVLQMfvmoZjNjEEa0CRQZpuvf3kfE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727016AbgCTROy (ORCPT ); Fri, 20 Mar 2020 13:14:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:46488 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726666AbgCTROx (ORCPT ); Fri, 20 Mar 2020 13:14:53 -0400 Received: from kicinski-fedora-PC1C0HJN (unknown [163.114.132.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E602F20709; Fri, 20 Mar 2020 17:14:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584724493; bh=wsQ9ZIqce6T8WDfwtxBoI75BeEpfI73B6LCZCTrvm/w=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=IGgZO4Tp0PQoYjFdDoTxzR4cUBZnGSxq3ZW8acBlBIdX/EFaIjI06SirfpHAr3wv3 Y6mToxghV0maF4ICA5FRQDH19eR0yYxGv08XRyQL0nEQMP3dMipKQtZjgo0LZcmX3D 1pvps0uPSBRlpuFfG19YqwGGQXnLGSRwSBQnyIrg= Date: Fri, 20 Mar 2020 10:14:51 -0700 From: Jakub Kicinski To: Sunil Kovvuri Cc: Andrew Lunn , Linux Netdev List , "David S. Miller" , Leon Romanovsky , Tomasz Duszynski , Sunil Goutham Subject: Re: [PATCH v3 net-next 4/8] octeontx2-vf: Ethtool support Message-ID: <20200320101451.0036a8cc@kicinski-fedora-PC1C0HJN> In-Reply-To: References: <1584623248-27508-1-git-send-email-sunil.kovvuri@gmail.com> <1584623248-27508-5-git-send-email-sunil.kovvuri@gmail.com> <20200319155631.GC27807@lunn.ch> <20200319154211.4bf7cf01@kicinski-fedora-PC1C0HJN> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 20 Mar 2020 12:35:15 +0530 Sunil Kovvuri wrote: > On Fri, Mar 20, 2020 at 4:12 AM Jakub Kicinski wrote: > > > > On Thu, 19 Mar 2020 16:56:31 +0100 Andrew Lunn wrote: > > > On Thu, Mar 19, 2020 at 06:37:24PM +0530, sunil.kovvuri@gmail.com wrote: > > > > From: Tomasz Duszynski > > > > > > > > Added ethtool support for VF devices for > > > > - Driver stats, Tx/Rx perqueue stats > > > > - Set/show Rx/Tx queue count > > > > - Set/show Rx/Tx ring sizes > > > > - Set/show IRQ coalescing parameters > > > > - RSS configuration etc > > > > > > > > It's the PF which owns the interface, hence VF > > > > cannot display underlying CGX interface stats. > > > > Except for this rest ethtool support reuses PF's > > > > APIs. > > > > > > > > Signed-off-by: Tomasz Duszynski > > > > Signed-off-by: Sunil Goutham > > > > > > Reviewed-by: Andrew Lunn > > > > But they didn't add static inlines, no? Don't the dependencies > > look strange? > > > > VF depends on PF code, but ethtool code (part of PF) also needs > > symbols from the VF.. > > > > ethtool code has no dependency on symbols from the VF driver. > PF driver compiles and module loads fine without enabling VF driver. > While getting rid of __weak fn()s i forgot to remove EXPORT symbols > from VF driver. > I will remove and resubmit. I see. I saw the exports and assumed it gets called. Thanks.