From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EA0FC10DCE for ; Tue, 24 Mar 2020 23:36:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 47CBC20724 for ; Tue, 24 Mar 2020 23:36:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727113AbgCXXgH (ORCPT ); Tue, 24 Mar 2020 19:36:07 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:37948 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726911AbgCXXgH (ORCPT ); Tue, 24 Mar 2020 19:36:07 -0400 Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id AC6DA159F5F6C; Tue, 24 Mar 2020 16:36:06 -0700 (PDT) Date: Tue, 24 Mar 2020 16:36:05 -0700 (PDT) Message-Id: <20200324.163605.1988277256387167758.davem@davemloft.net> To: ybason@marvell.com Cc: netdev@vger.kernel.org, dbolotin@marvell.com Subject: Re: [PATCH net-next 1/3] qed: Replace wq_active Boolean with an atomic QED_SLOWPATH_ACTIVE flag From: David Miller In-Reply-To: <20200324141348.7897-2-ybason@marvell.com> References: <20200324141348.7897-1-ybason@marvell.com> <20200324141348.7897-2-ybason@marvell.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 24 Mar 2020 16:36:06 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Yuval Basson Date: Tue, 24 Mar 2020 16:13:46 +0200 > The atomic opertaion might prevent a potential race condition. > > Signed-off-by: Yuval Basson > Signed-off-by: Denis Bolotin There is no basis in fact behind this change. Either explain clearly and precisely what race is fixed by this change or remove this change. Thank you.