From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39CF5C2D0E5 for ; Wed, 25 Mar 2020 17:56:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 10C0F2077D for ; Wed, 25 Mar 2020 17:56:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585158972; bh=YwPjdZJNqrQcjC1PKVYfHeOg+tRZT+OKwQ21NuDgRGg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=jj3xMdI3d7H4UIkIB8PzVAkjsa+8s2ytcZ1qcc0nliYarThQOld1q0M42cQZtJf72 0tHBs5hWiHo6EiGIqwRqpkVvyZnSGjHSHsLYwJUhyZTnUtjgOoYU1DsaOZs2qlaKgX AYQ9/bPmTfm45iDHAWZspsRSzxQUuW2tc3gJc0T0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727355AbgCYR4L (ORCPT ); Wed, 25 Mar 2020 13:56:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:38002 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726102AbgCYR4L (ORCPT ); Wed, 25 Mar 2020 13:56:11 -0400 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6409E206F6; Wed, 25 Mar 2020 17:56:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585158970; bh=YwPjdZJNqrQcjC1PKVYfHeOg+tRZT+OKwQ21NuDgRGg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ambj0ETkawa8Halt9b2sXA6MPyKMrC+W9IpZynEyXCd+c/1owoL9gellkfa3EPE+3 n+Z/viPRGrwTKVujVIhnFmskEwqzeN72zLrajghcNlRazEcosmBLaadnBq6sE/C04/ SWt4l0WEAuFP0s2LmXdx3bp4Y1J4E9Ka5uH6u4yw= Date: Wed, 25 Mar 2020 10:56:08 -0700 From: Jakub Kicinski To: Jacob Keller Cc: netdev@vger.kernel.org, Jiri Pirko , Jiri Pirko Subject: Re: [PATCH 04/10] devlink: add function to take snapshot while locked Message-ID: <20200325105608.13077942@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20200324223445.2077900-5-jacob.e.keller@intel.com> References: <20200324223445.2077900-1-jacob.e.keller@intel.com> <20200324223445.2077900-5-jacob.e.keller@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 24 Mar 2020 15:34:39 -0700 Jacob Keller wrote: > A future change is going to add a new devlink command to request > a snapshot on demand. This function will want to call the > devlink_region_snapshot_create function while already holding the > devlink instance lock. > > Extract the logic of this function into a static function prefixed by > `__` to indicate that it is an internal helper function. Modify the > original function to be implemented in terms of the new locked > function. > > Signed-off-by: Jacob Keller > Reviewed-by: Jiri Pirko Reviewed-by: Jakub Kicinski