From: Florian Westphal <fw@strlen.de>
To: Qian Cai <cai@lca.pw>
Cc: pablo@netfilter.org, kadlec@netfilter.org, fw@strlen.de,
davem@davemloft.net, netfilter-devel@vger.kernel.org,
coreteam@netfilter.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] netfilter/nf_tables: silence a RCU-list warning
Date: Thu, 26 Mar 2020 00:13:50 +0100 [thread overview]
Message-ID: <20200325231350.GC878@breakpoint.cc> (raw)
In-Reply-To: <20200325143142.6955-1-cai@lca.pw>
Qian Cai <cai@lca.pw> wrote:
> It is safe to traverse &net->nft.tables with &net->nft.commit_mutex
> held using list_for_each_entry_rcu(). Silence the PROVE_RCU_LIST false
> positive,
[..]
> - list_for_each_entry_rcu(table, &net->nft.tables, list) {
> + list_for_each_entry_rcu(table, &net->nft.tables, list,
> + lockdep_is_held(&net->nft.commit_mutex)) {
Thanks for the patch.
Acked-by: Florian Westphal <fw@strlen.de>
next prev parent reply other threads:[~2020-03-25 23:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 14:31 [PATCH] netfilter/nf_tables: silence a RCU-list warning Qian Cai
2020-03-25 23:13 ` Florian Westphal [this message]
2020-03-26 13:46 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200325231350.GC878@breakpoint.cc \
--to=fw@strlen.de \
--cc=cai@lca.pw \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=kadlec@netfilter.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).