From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 761E1C43331 for ; Thu, 26 Mar 2020 18:55:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 53D4C20714 for ; Thu, 26 Mar 2020 18:55:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727919AbgCZSz6 (ORCPT ); Thu, 26 Mar 2020 14:55:58 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:52738 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725994AbgCZSz6 (ORCPT ); Thu, 26 Mar 2020 14:55:58 -0400 Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id E55A415CBC249; Thu, 26 Mar 2020 11:55:56 -0700 (PDT) Date: Thu, 26 Mar 2020 11:55:55 -0700 (PDT) Message-Id: <20200326.115555.620787715117935635.davem@davemloft.net> To: idosch@idosch.org Cc: netdev@vger.kernel.org, kuba@kernel.org, jiri@mellanox.com, petrm@mellanox.com, mlxsw@mellanox.com, idosch@mellanox.com Subject: Re: [PATCH net-next 0/6] mlxsw: Offload TC action pedit munge dsfield From: David Miller In-Reply-To: <20200326140114.1393972-1-idosch@idosch.org> References: <20200326140114.1393972-1-idosch@idosch.org> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 26 Mar 2020 11:55:57 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Ido Schimmel Date: Thu, 26 Mar 2020 16:01:08 +0200 > From: Ido Schimmel > > Petr says: > > The Spectrum switches allow packet prioritization based on DSCP on ingress, > and update of DSCP on egress. This is configured through the DCB APP rules. > For some use cases, assigning a custom DSCP value based on an ACL match is > a better tool. To that end, offload FLOW_ACTION_MANGLE to permit changing > of dsfield as a whole, or DSCP and ECN values in isolation. > > After fixing a commentary nit in patch #1, and mlxsw naming in patch #2, > patches #3 and #4 add the offload to mlxsw. > > Patch #5 adds a forwarding selftest for pedit dsfield, applicable to SW as > well as HW datapaths. Patch #6 adds a mlxsw-specific test to verify DSCP > rewrite due to DCB APP rules is not performed on pedited packets. > > The tests only cover IPv4 dsfield setting. We have tests for IPv6 as well, > but would like to postpone their contribution until the corresponding > iproute patches have been accepted. Series applied, thanks.