From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A289BC43331 for ; Thu, 26 Mar 2020 19:01:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 820BC20722 for ; Thu, 26 Mar 2020 19:01:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727984AbgCZTBb (ORCPT ); Thu, 26 Mar 2020 15:01:31 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:52800 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725994AbgCZTBb (ORCPT ); Thu, 26 Mar 2020 15:01:31 -0400 Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id B231815CB9BD9; Thu, 26 Mar 2020 12:01:30 -0700 (PDT) Date: Thu, 26 Mar 2020 12:01:29 -0700 (PDT) Message-Id: <20200326.120129.10247438354279964.davem@davemloft.net> To: idosch@idosch.org Cc: netdev@vger.kernel.org, jiri@mellanox.com, mlxsw@mellanox.com, idosch@mellanox.com Subject: Re: [PATCH net] mlxsw: spectrum_mr: Fix list iteration in error path From: David Miller In-Reply-To: <20200326141733.1395337-1-idosch@idosch.org> References: <20200326141733.1395337-1-idosch@idosch.org> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 26 Mar 2020 12:01:31 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Ido Schimmel Date: Thu, 26 Mar 2020 16:17:33 +0200 > From: Ido Schimmel > > list_for_each_entry_from_reverse() iterates backwards over the list from > the current position, but in the error path we should start from the > previous position. > > Fix this by using list_for_each_entry_continue_reverse() instead. > > This suppresses the following error from coccinelle: > > drivers/net/ethernet/mellanox/mlxsw//spectrum_mr.c:655:34-38: ERROR: > invalid reference to the index variable of the iterator on line 636 > > Fixes: c011ec1bbfd6 ("mlxsw: spectrum: Add the multicast routing offloading logic") > Signed-off-by: Ido Schimmel > Reviewed-by: Jiri Pirko Applied and queued up for -stable, thanks.