From: Jiri Pirko <jiri@resnulli.us>
To: Vasundhara Volam <vasundhara-v.volam@broadcom.com>
Cc: David Miller <davem@davemloft.net>,
Netdev <netdev@vger.kernel.org>, Jiri Pirko <jiri@mellanox.com>,
Michael Chan <michael.chan@broadcom.com>
Subject: Re: [PATCH v2 net-next 3/7] devlink: Add macro for "hw.addr" to info_get cb.
Date: Thu, 26 Mar 2020 16:54:29 +0100 [thread overview]
Message-ID: <20200326155429.GZ11304@nanopsycho.orion> (raw)
In-Reply-To: <CAACQVJoA5EpB1CQUHvzDgYS0O7XLZ4vNbVvGALqc8nkf4-+VgA@mail.gmail.com>
Thu, Mar 26, 2020 at 12:02:43PM CET, vasundhara-v.volam@broadcom.com wrote:
>On Thu, Mar 26, 2020 at 2:56 PM Jiri Pirko <jiri@resnulli.us> wrote:
>>
>> Thu, Mar 26, 2020 at 07:27:00AM CET, vasundhara-v.volam@broadcom.com wrote:
>> >Add definition and documentation for the new generic info "hw.addr".
>> >"hw.addr" displays the hardware address of the interface.
>> >
>> >Cc: Jiri Pirko <jiri@mellanox.com>
>> >Signed-off-by: Vasundhara Volam <vasundhara-v.volam@broadcom.com>
>> >Signed-off-by: Michael Chan <michael.chan@broadcom.com>
>> >---
>> > Documentation/networking/devlink/devlink-info.rst | 5 +++++
>> > include/net/devlink.h | 3 +++
>> > 2 files changed, 8 insertions(+)
>> >
>> >diff --git a/Documentation/networking/devlink/devlink-info.rst b/Documentation/networking/devlink/devlink-info.rst
>> >index 650e2c0e3..56d13c5 100644
>> >--- a/Documentation/networking/devlink/devlink-info.rst
>> >+++ b/Documentation/networking/devlink/devlink-info.rst
>> >@@ -144,6 +144,11 @@ board.manufacture
>> >
>> > An identifier of the company or the facility which produced the part.
>> >
>> >+hw.addr
>> >+-------
>> >+
>> >+Hardware address of the interface.
>> >+
>> > fw
>> > --
>> >
>> >diff --git a/include/net/devlink.h b/include/net/devlink.h
>> >index d51482f..c9383f4 100644
>> >--- a/include/net/devlink.h
>> >+++ b/include/net/devlink.h
>> >@@ -476,6 +476,9 @@ enum devlink_param_generic_id {
>> > /* Revision of asic design */
>> > #define DEVLINK_INFO_VERSION_GENERIC_ASIC_REV "asic.rev"
>> >
>> >+/* Hardware address */
>> >+#define DEVLINK_INFO_VERSION_GENERIC_HW_ADDR "hw.addr"
>>
>> Wait a second. Is this a MAC. I don't understand why MAC would be here.
>Yes, this is MAC address. Since, most of the information is displayed
>via info_get
>as one place. Would like to display MAC address as well under info_get.
No, I don't want to display mac here. It is a netdevice attribute. Leave
it there.
>
>Thanks,
>Vasundhara
>
>
>> If not MAC, what is exactly this address about?
>>
>>
>> >+
>> > /* Overall FW version */
>> > #define DEVLINK_INFO_VERSION_GENERIC_FW "fw"
>> > /* Overall FW interface specification version */
>> >--
>> >1.8.3.1
>> >
next prev parent reply other threads:[~2020-03-26 15:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 6:26 [PATCH v2 net-next 0/7] bnxt_en: Updates to devlink info_get cb Vasundhara Volam
2020-03-26 6:26 ` [PATCH v2 net-next 1/7] devlink: Add macro for "fw.api" to " Vasundhara Volam
2020-03-26 9:28 ` Jiri Pirko
2020-03-26 6:26 ` [PATCH v2 net-next 2/7] bnxt_en: Add fw.api version to devlink " Vasundhara Volam
2020-03-26 6:27 ` [PATCH v2 net-next 3/7] devlink: Add macro for "hw.addr" to " Vasundhara Volam
2020-03-26 9:26 ` Jiri Pirko
2020-03-26 11:02 ` Vasundhara Volam
2020-03-26 15:54 ` Jiri Pirko [this message]
2020-03-26 16:03 ` Vasundhara Volam
2020-03-26 6:27 ` [PATCH v2 net-next 4/7] bnxt_en: Add hw addr to devlink " Vasundhara Volam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200326155429.GZ11304@nanopsycho.orion \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=jiri@mellanox.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=vasundhara-v.volam@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).