From: Andrew Lunn <andrew@lunn.ch>
To: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Cc: Ioana Ciornei <ioana.ciornei@nxp.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 2/2] net: phylink: add separate pcs operations structure
Date: Sun, 29 Mar 2020 17:10:59 +0200 [thread overview]
Message-ID: <20200329151059.GB31812@lunn.ch> (raw)
In-Reply-To: <20200329114741.GZ25745@shell.armlinux.org.uk>
> The pcs_config() method should set the PCS according to the interface
> mode (state->interface) and the advertisement (state->advertising).
> Nothing else should be used. I suppose I should pass those explicitly
> rather than the whole state structure to prevent any mis-use.
Hi Russell
I think that has been a learning from phylink so far. Only pass what
you are supposed to act on, nothing more.
Andrew
next prev parent reply other threads:[~2020-03-29 15:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 15:14 [PATCH net-next 0/2] split phylink PCS operations and add PCS support for dpaa2 Russell King - ARM Linux admin
2020-03-26 15:15 ` [PATCH net-next 1/2] net: phylink: rename 'ops' to 'mac_ops' Russell King
2020-03-26 15:15 ` [PATCH net-next 2/2] net: phylink: add separate pcs operations structure Russell King
2020-03-26 21:49 ` Ioana Ciornei
2020-03-29 11:47 ` Russell King - ARM Linux admin
2020-03-29 15:10 ` Andrew Lunn [this message]
2020-03-26 15:19 ` [PATCH net-next 0/2] split phylink PCS operations and add PCS support for dpaa2 Russell King - ARM Linux admin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200329151059.GB31812@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=ioana.ciornei@nxp.com \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).