From: Rob Herring <robh@kernel.org>
To: Tobias Waldekranz <tobias@waldekranz.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, andrew@lunn.ch,
f.fainelli@gmail.com, hkallweit1@gmail.com,
linux-usb@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: net: add marvell usb to mdio bindings
Date: Mon, 30 Mar 2020 09:11:24 -0600 [thread overview]
Message-ID: <20200330151124.GA30148@bogus> (raw)
In-Reply-To: <20200321202443.15352-1-tobias@waldekranz.com>
On Sat, Mar 21, 2020 at 09:24:42PM +0100, Tobias Waldekranz wrote:
> Describe how the USB to MDIO controller can optionally use device tree
> bindings to reference attached devices such as switches.
Looks like this is in linux-next now. First I'm seeing it because the DT
list was not Cc'ed.
This is breaking 'make dt_binding_check'. Revert or fix before this goes
to Linus please.
> Signed-off-by: Tobias Waldekranz <tobias@waldekranz.com>
> ---
> .../bindings/net/marvell,mvusb.yaml | 65 +++++++++++++++++++
> MAINTAINERS | 6 ++
> 2 files changed, 71 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/net/marvell,mvusb.yaml
>
> diff --git a/Documentation/devicetree/bindings/net/marvell,mvusb.yaml b/Documentation/devicetree/bindings/net/marvell,mvusb.yaml
> new file mode 100644
> index 000000000000..9458f6659be1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/marvell,mvusb.yaml
> @@ -0,0 +1,65 @@
> +# SPDX-License-Identifier: GPL-2.0
New bindings should be:
(GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/marvell,mvusb.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Marvell USB to MDIO Controller
> +
> +maintainers:
> + - Tobias Waldekranz <tobias@waldekranz.com>
> +
> +description: |+
> + This controller is mounted on development boards for Marvell's Link Street
> + family of Ethernet switches. It allows you to configure the switch's registers
> + using the standard MDIO interface.
> +
> + Since the device is connected over USB, there is no strict requirement of
> + having a device tree representation of the device. But in order to use it with
> + the mv88e6xxx driver, you need a device tree node in which to place the switch
> + definition.
> +
> +allOf:
> + - $ref: "mdio.yaml#"
> +
> +properties:
> + compatible:
> + const: usb1286,1fa4
> + reg:
> + maxItems: 1
> + description: The USB port number on the host controller
Really, it's the port on the hub which could be a root hub.
> +
> +required:
> + - compatible
> + - reg
> + - "#address-cells"
> + - "#size-cells"
> +
> +examples:
> + - |
> + /* USB host controller */
> + &usb1 {
This won't compile because there's no 'usb1' to reference.
> + mvusb: mdio@1 {
> + compatible = "usb1286,1fa4";
> + reg = <1>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + };
> + };
> +
> + /* MV88E6390X devboard */
> + &mvusb {
Move this into the above node.
> + switch@0 {
> + compatible = "marvell,mv88e6190";
> + status = "ok";
Don't show status in examples.
> + reg = <0x0>;
> +
> + ports {
> + /* Port definitions */
Incomplete examples will eventually fail as when complete schema are
present.
> + };
> +
> + mdio {
> + /* PHY definitions */
> + };
> + };
> + };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 97dce264bc7c..ff35669f8712 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -10101,6 +10101,12 @@ M: Nicolas Pitre <nico@fluxnic.net>
> S: Odd Fixes
> F: drivers/mmc/host/mvsdio.*
>
> +MARVELL USB MDIO CONTROLLER DRIVER
> +M: Tobias Waldekranz <tobias@waldekranz.com>
> +L: netdev@vger.kernel.org
> +S: Maintained
> +F: Documentation/devicetree/bindings/net/marvell,mvusb.yaml
> +
> MARVELL XENON MMC/SD/SDIO HOST CONTROLLER DRIVER
> M: Hu Ziji <huziji@marvell.com>
> L: linux-mmc@vger.kernel.org
> --
> 2.17.1
>
prev parent reply other threads:[~2020-03-30 15:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-21 20:24 [PATCH v3 1/2] dt-bindings: net: add marvell usb to mdio bindings Tobias Waldekranz
2020-03-21 20:24 ` [PATCH v3 2/2] net: phy: add marvell usb to mdio controller Tobias Waldekranz
2020-03-22 7:40 ` Greg KH
2020-03-22 9:09 ` Tobias Waldekranz
2020-03-22 11:10 ` Greg KH
2020-03-22 13:32 ` Andrew Lunn
2020-03-22 21:10 ` Florian Fainelli
2020-03-22 13:33 ` [PATCH v3 1/2] dt-bindings: net: add marvell usb to mdio bindings Andrew Lunn
2020-03-22 13:35 ` Andrew Lunn
2020-03-22 14:38 ` Tobias Waldekranz
2020-03-22 21:03 ` Florian Fainelli
2020-03-30 15:11 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200330151124.GA30148@bogus \
--to=robh@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tobias@waldekranz.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).