From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, jgg@mellanox.com,
maxime.coquelin@redhat.com, cunming.liang@intel.com,
zhihong.wang@intel.com, rob.miller@broadcom.com,
xiao.w.wang@intel.com, lingshan.zhu@intel.com,
eperezma@redhat.com, lulu@redhat.com, parav@mellanox.com,
kevin.tian@intel.com, stefanha@redhat.com, rdunlap@infradead.org,
hch@infradead.org, aadam@redhat.com, jiri@mellanox.com,
shahafs@mellanox.com, hanand@xilinx.com, mhabets@solarflare.com,
gdawar@xilinx.com, saugatm@xilinx.com, vmireyno@marvell.com,
zhangweining@ruijie.com.cn
Subject: Re: [PATCH V9 1/9] vhost: refine vhost and vringh kconfig
Date: Wed, 1 Apr 2020 11:57:14 -0400 [thread overview]
Message-ID: <20200401115650-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <5e409bb4-2b06-5193-20c3-a9ddaafacf5a@redhat.com>
On Wed, Apr 01, 2020 at 10:50:50PM +0800, Jason Wang wrote:
>
> On 2020/4/1 下午10:27, Michael S. Tsirkin wrote:
> > On Wed, Apr 01, 2020 at 10:13:29PM +0800, Jason Wang wrote:
> > > On 2020/4/1 下午9:02, Christian Borntraeger wrote:
> > > > On 01.04.20 14:56, Christian Borntraeger wrote:
> > > > > On 01.04.20 14:50, Jason Wang wrote:
> > > > > > On 2020/4/1 下午7:21, Christian Borntraeger wrote:
> > > > > > > On 26.03.20 15:01, Jason Wang wrote:
> > > > > > > > Currently, CONFIG_VHOST depends on CONFIG_VIRTUALIZATION. But vhost is
> > > > > > > > not necessarily for VM since it's a generic userspace and kernel
> > > > > > > > communication protocol. Such dependency may prevent archs without
> > > > > > > > virtualization support from using vhost.
> > > > > > > >
> > > > > > > > To solve this, a dedicated vhost menu is created under drivers so
> > > > > > > > CONIFG_VHOST can be decoupled out of CONFIG_VIRTUALIZATION.
> > > > > > > FWIW, this now results in vhost not being build with defconfig kernels (in todays
> > > > > > > linux-next).
> > > > > > >
> > > > > > Hi Christian:
> > > > > >
> > > > > > Did you meet it even with this commit https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=a4be40cbcedba9b5b714f3c95182e8a45176e42d?
> > > > > I simply used linux-next. The defconfig does NOT contain CONFIG_VHOST and therefore CONFIG_VHOST_NET and friends
> > > > > can not be selected.
> > > > >
> > > > > $ git checkout next-20200401
> > > > > $ make defconfig
> > > > > HOSTCC scripts/basic/fixdep
> > > > > HOSTCC scripts/kconfig/conf.o
> > > > > HOSTCC scripts/kconfig/confdata.o
> > > > > HOSTCC scripts/kconfig/expr.o
> > > > > LEX scripts/kconfig/lexer.lex.c
> > > > > YACC scripts/kconfig/parser.tab.[ch]
> > > > > HOSTCC scripts/kconfig/lexer.lex.o
> > > > > HOSTCC scripts/kconfig/parser.tab.o
> > > > > HOSTCC scripts/kconfig/preprocess.o
> > > > > HOSTCC scripts/kconfig/symbol.o
> > > > > HOSTCC scripts/kconfig/util.o
> > > > > HOSTLD scripts/kconfig/conf
> > > > > *** Default configuration is based on 'x86_64_defconfig'
> > > > > #
> > > > > # configuration written to .config
> > > > > #
> > > > >
> > > > > $ grep VHOST .config
> > > > > # CONFIG_VHOST is not set
> > > > >
> > > > > > If yes, what's your build config looks like?
> > > > > >
> > > > > > Thanks
> > > > This was x86. Not sure if that did work before.
> > > > On s390 this is definitely a regression as the defconfig files
> > > > for s390 do select VHOST_NET
> > > >
> > > > grep VHOST arch/s390/configs/*
> > > > arch/s390/configs/debug_defconfig:CONFIG_VHOST_NET=m
> > > > arch/s390/configs/debug_defconfig:CONFIG_VHOST_VSOCK=m
> > > > arch/s390/configs/defconfig:CONFIG_VHOST_NET=m
> > > > arch/s390/configs/defconfig:CONFIG_VHOST_VSOCK=m
> > > >
> > > > and this worked with 5.6, but does not work with next. Just adding
> > > > CONFIG_VHOST=m to the defconfig solves the issue, something like
> > >
> > > Right, I think we probably need
> > >
> > > 1) add CONFIG_VHOST=m to all defconfigs that enables
> > > CONFIG_VHOST_NET/VSOCK/SCSI.
> > >
> > > or
> > >
> > > 2) don't use menuconfig for CONFIG_VHOST, let NET/SCSI/VDPA just select it.
> > >
> > > Thanks
> > OK I tried this:
> >
> > diff --git a/drivers/vhost/Kconfig b/drivers/vhost/Kconfig
> > index 2523a1d4290a..a314b900d479 100644
> > --- a/drivers/vhost/Kconfig
> > +++ b/drivers/vhost/Kconfig
> > @@ -19,11 +19,10 @@ menuconfig VHOST
> > This option is selected by any driver which needs to access
> > the core of vhost.
> > -if VHOST
> > -
> > config VHOST_NET
> > tristate "Host kernel accelerator for virtio net"
> > depends on NET && EVENTFD && (TUN || !TUN) && (TAP || !TAP)
> > + select VHOST
> > ---help---
> > This kernel module can be loaded in host kernel to accelerate
> > guest networking with virtio_net. Not to be confused with virtio_net
> > @@ -35,6 +34,7 @@ config VHOST_NET
> > config VHOST_SCSI
> > tristate "VHOST_SCSI TCM fabric driver"
> > depends on TARGET_CORE && EVENTFD
> > + select VHOST
> > default n
> > ---help---
> > Say M here to enable the vhost_scsi TCM fabric module
> > @@ -44,6 +44,7 @@ config VHOST_VSOCK
> > tristate "vhost virtio-vsock driver"
> > depends on VSOCKETS && EVENTFD
> > select VIRTIO_VSOCKETS_COMMON
> > + select VHOST
> > default n
> > ---help---
> > This kernel module can be loaded in the host kernel to provide AF_VSOCK
> > @@ -57,6 +58,7 @@ config VHOST_VDPA
> > tristate "Vhost driver for vDPA-based backend"
> > depends on EVENTFD
> > select VDPA
> > + select VHOST
> > help
> > This kernel module can be loaded in host kernel to accelerate
> > guest virtio devices with the vDPA-based backends.
> > @@ -78,5 +80,3 @@ config VHOST_CROSS_ENDIAN_LEGACY
> > adds some overhead, it is disabled by default.
> > If unsure, say "N".
> > -
> > -endif
> >
> >
> > But now CONFIG_VHOST is always "y", never "m".
> > Which I think will make it a built-in.
> > Didn't figure out why yet.
>
>
> Is it because the dependency of EVENTFD for CONFIG_VHOST?
Oh no, it's because I forgot to change menuconfig to config.
> Remove that one for this patch, I can get CONFIG_VHOST=m.
>
> But according to documentation/kbuild/kconfig.rst, select is used for option
> without prompt.
>
> Thanks
>
>
> >
next prev parent reply other threads:[~2020-04-01 15:57 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 14:01 [PATCH V9 0/9] vDPA support Jason Wang
2020-03-26 14:01 ` [PATCH V9 1/9] vhost: refine vhost and vringh kconfig Jason Wang
2020-04-01 11:21 ` Christian Borntraeger
2020-04-01 12:50 ` Jason Wang
2020-04-01 12:56 ` Christian Borntraeger
2020-04-01 13:02 ` Christian Borntraeger
2020-04-01 14:01 ` Michael S. Tsirkin
2020-04-01 14:13 ` Jason Wang
2020-04-01 14:18 ` Michael S. Tsirkin
2020-04-01 14:36 ` Jason Wang
2020-04-01 14:27 ` Michael S. Tsirkin
2020-04-01 14:50 ` Jason Wang
2020-04-01 15:57 ` Michael S. Tsirkin [this message]
2020-04-01 18:53 ` Christian Borntraeger
2020-04-01 13:22 ` Michael S. Tsirkin
2020-04-01 14:08 ` Jason Wang
2020-04-01 14:13 ` Michael S. Tsirkin
2020-04-01 14:29 ` Jason Wang
2020-04-01 14:35 ` Michael S. Tsirkin
2020-04-01 14:39 ` Jason Wang
2020-04-01 14:39 ` Michael S. Tsirkin
2020-04-01 14:43 ` Jason Wang
2020-04-01 16:05 ` Michael S. Tsirkin
2020-04-01 16:08 ` Michael S. Tsirkin
2020-04-02 3:22 ` Jason Wang
2020-04-02 14:03 ` Michael S. Tsirkin
2020-04-02 14:23 ` Jason Wang
2020-04-02 14:38 ` Michael S. Tsirkin
2020-04-02 14:56 ` Jason Wang
2020-03-26 14:01 ` [PATCH V9 2/9] vhost: allow per device message handler Jason Wang
2020-03-26 14:01 ` [PATCH V9 3/9] vhost: factor out IOTLB Jason Wang
2020-03-26 14:01 ` [PATCH V9 4/9] vringh: IOTLB support Jason Wang
2020-03-26 14:01 ` [PATCH V9 5/9] vDPA: introduce vDPA bus Jason Wang
2020-03-26 14:01 ` [PATCH V9 6/9] virtio: introduce a vDPA based transport Jason Wang
2020-03-26 14:01 ` [PATCH V9 7/9] vhost: introduce vDPA-based backend Jason Wang
2021-11-01 14:11 ` Jason Gunthorpe
2021-11-02 3:52 ` Jason Wang
2021-11-02 15:56 ` Jason Gunthorpe
2021-11-03 7:34 ` Jason Wang
2020-03-26 14:01 ` [PATCH V9 8/9] vdpasim: vDPA device simulator Jason Wang
2020-04-10 7:45 ` Geert Uytterhoeven
2020-04-10 8:23 ` Jason Wang
2020-03-26 14:01 ` [PATCH V9 9/9] virtio: Intel IFC VF driver for VDPA Jason Wang
2020-04-09 10:41 ` Arnd Bergmann
2020-04-09 12:43 ` Jason Wang
2020-04-09 12:49 ` Zhu, Lingshan
2020-04-09 20:25 ` Michael S. Tsirkin
2020-04-10 3:15 ` Zhu, Lingshan
2020-03-29 11:07 ` [PATCH V9 0/9] vDPA support Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200401115650-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=aadam@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cunming.liang@intel.com \
--cc=eperezma@redhat.com \
--cc=gdawar@xilinx.com \
--cc=hanand@xilinx.com \
--cc=hch@infradead.org \
--cc=jasowang@redhat.com \
--cc=jgg@mellanox.com \
--cc=jiri@mellanox.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=lingshan.zhu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lulu@redhat.com \
--cc=maxime.coquelin@redhat.com \
--cc=mhabets@solarflare.com \
--cc=netdev@vger.kernel.org \
--cc=parav@mellanox.com \
--cc=rdunlap@infradead.org \
--cc=rob.miller@broadcom.com \
--cc=saugatm@xilinx.com \
--cc=shahafs@mellanox.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=vmireyno@marvell.com \
--cc=xiao.w.wang@intel.com \
--cc=zhangweining@ruijie.com.cn \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).