Netdev Archive on
 help / color / Atom feed
From: David Miller <>
Subject: Re: [PATCH net] net/sched: Don't print dump stack in event of transmission timeout
Date: Thu, 02 Apr 2020 18:02:18 -0700 (PDT)
Message-ID: <> (raw)
In-Reply-To: <>

From: Leon Romanovsky <>
Date: Thu,  2 Apr 2020 18:23:36 +0300

> In event of transmission timeout, the drivers are given an opportunity
> to recover and continue to work after some in-house cleanups.
> Such event can be caused by HW bugs, wrong congestion configurations
> and many more other scenarios. In such case, users are interested to
> get a simple  "NETDEV WATCHDOG ... " print, which points to the relevant
> netdevice in trouble.
> The dump stack printed later was added in the commit b4192bbd85d2
> ("net: Add a WARN_ON_ONCE() to the transmit timeout function") to give
> extra information, like list of the modules and which driver is involved.
> While the latter is already printed in "NETDEV WATCHDOG ... ", the list
> of modules rarely needed and can be collected later.
> So let's remove the WARN_ONCE() and make dmesg look more user-friendly in
> large cluster setups.

Software bugs play into these situations and on at least two or three
occasions I know that the backtrace hinted at the cause of the bug.

I'm not applying this, sorry.

  parent reply index

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-02 15:23 Leon Romanovsky
2020-04-02 22:57 ` Jakub Kicinski
2020-04-03  4:33   ` Cong Wang
2020-04-03  4:48   ` Leon Romanovsky
2020-04-03  1:02 ` David Miller [this message]
2020-04-03  4:30   ` Cong Wang
2020-04-03  4:36     ` Leon Romanovsky
2020-04-03  4:40   ` Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Netdev Archive on

Archives are clonable:
	git clone --mirror netdev/git/0.git
	git clone --mirror netdev/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 netdev netdev/ \
	public-inbox-index netdev

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone