From: David Miller <davem@davemloft.net>
To: leon@kernel.org
Cc: ka-cheong.poon@oracle.com, netdev@vger.kernel.org,
santosh.shilimkar@oracle.com, rds-devel@oss.oracle.com,
sironhide0null@gmail.com
Subject: Re: [PATCH net 1/2] net/rds: Replace direct refcount_inc() by inline function
Date: Tue, 07 Apr 2020 13:19:11 -0700 (PDT) [thread overview]
Message-ID: <20200407.131911.2253144379787989145.davem@davemloft.net> (raw)
In-Reply-To: <20200407184809.GP80989@unreal>
From: Leon Romanovsky <leon@kernel.org>
Date: Tue, 7 Apr 2020 21:48:09 +0300
> On Tue, Apr 07, 2020 at 09:08:01AM -0700, Ka-Cheong Poon wrote:
>> Added rds_ib_dev_get() and rds_mr_get() to improve code readability.
>
> It is very hard to agree with this sentence.
> Hiding basic kernel primitives is very rare will improve code readability.
> It is definitely not the case here.
I completely agree.
next prev parent reply other threads:[~2020-04-07 20:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-07 16:08 [PATCH net 1/2] net/rds: Replace direct refcount_inc() by inline function Ka-Cheong Poon
2020-04-07 16:08 ` [PATCH net 2/2] net/rds: Fix MR reference counting problem Ka-Cheong Poon
2020-04-07 19:30 ` santosh.shilimkar
2020-04-08 2:25 ` zerons
2020-04-08 2:52 ` santosh.shilimkar
2020-04-07 18:48 ` [PATCH net 1/2] net/rds: Replace direct refcount_inc() by inline function Leon Romanovsky
2020-04-07 20:19 ` David Miller [this message]
2020-04-08 4:15 ` Ka-Cheong Poon
2020-04-08 6:44 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200407.131911.2253144379787989145.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ka-cheong.poon@oracle.com \
--cc=leon@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rds-devel@oss.oracle.com \
--cc=santosh.shilimkar@oracle.com \
--cc=sironhide0null@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).