From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D134C2BBC7 for ; Sat, 11 Apr 2020 23:25:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EAAAB20769 for ; Sat, 11 Apr 2020 23:24:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586647500; bh=DL7FZWMXVY7jVUP98TMif3m59vlVfWQB0U8iPAGHm9M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=r24KSLmB4XfKWpBMIS8Pt+kEUkZm+Il32DgPWcnBh4RYZ8bOFjeRMrTjPCHBMeGR6 l/dh18GqeqDhUbmwA8pdtTzQaIggHrXPvr7Iife0JDIvfPJoB2O/6GPlj354olxa4e 5cjFceBEHmu5f1RP84pmwlv8IhYYz/uf1DuPImx0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728935AbgDKXY4 (ORCPT ); Sat, 11 Apr 2020 19:24:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:52428 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730148AbgDKXMW (ORCPT ); Sat, 11 Apr 2020 19:12:22 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4499520757; Sat, 11 Apr 2020 23:12:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586646743; bh=DL7FZWMXVY7jVUP98TMif3m59vlVfWQB0U8iPAGHm9M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CTD8bVijkDo7Up2UG3Soq0x1zwP4m5B3vGG5s+NXGwNPRencNPAlV5kIbtFFB2sA6 yoq/z5+zT01iGbDtQhlr9+oIBJN1YwyDf1ltxQSWxfADJ281QWJ4BLUv1CV8PcsVVY Yc0jyk+hgGuFh3gpcdJ/1/M3DwVc+BNWAbxw9JyM= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Vlad Buslov , Roi Dayan , Sasha Levin , netdev@vger.kernel.org, linux-rdma@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 16/66] net/mlx5e: Init ethtool steering for representors Date: Sat, 11 Apr 2020 19:11:13 -0400 Message-Id: <20200411231203.25933-16-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200411231203.25933-1-sashal@kernel.org> References: <20200411231203.25933-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Vlad Buslov [ Upstream commit 6783e8b29f636383af293a55336f036bc7ad5619 ] During transition to uplink representors the code responsible for initializing ethtool steering functionality wasn't added to representor init rx routine. This causes NULL pointer dereference during configuration of network flow classification rule with ethtool (only possible to reproduce with next commit in this series which registers necessary ethtool callbacks). Signed-off-by: Vlad Buslov Reviewed-by: Roi Dayan Signed-off-by: Sasha Levin --- drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c index 701624a63d2f4..d70af8a8e8b48 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c @@ -1022,6 +1022,8 @@ static int mlx5e_init_rep_rx(struct mlx5e_priv *priv) } rpriv->vport_rx_rule = flow_rule; + mlx5e_ethtool_init_steering(priv); + return 0; err_destroy_direct_tirs: -- 2.20.1