From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9BD6C2BA19 for ; Mon, 13 Apr 2020 11:33:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8846B20692 for ; Mon, 13 Apr 2020 11:33:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586777613; bh=28rP04l7BrPu7uLKpbtNd+EGfa/QFLZfAPq4HSjmE0w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=qCYzQ6U5jT+KCTfGj1d7IB5WDbInTmrPBnttiMnPloOlv5qZXPhniQ/zdYbJwQgSF 8XEkNXkgnYTIK09ndnFrbxzf/De2d4smdExcOiyKq5L0u/DeRf8q38RXHdgz/Nb0Vb 8I8wf7ayIJiRaZItnFkI0PCMFCFwsGNXrg11BN4A= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729002AbgDMLdc (ORCPT ); Mon, 13 Apr 2020 07:33:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:51206 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728883AbgDMLZe (ORCPT ); Mon, 13 Apr 2020 07:25:34 -0400 Received: from localhost (unknown [213.57.247.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D733A20732; Mon, 13 Apr 2020 11:25:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586777134; bh=28rP04l7BrPu7uLKpbtNd+EGfa/QFLZfAPq4HSjmE0w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ns5IWQZGccQYaOdvkcVcBWVZwiKjkOIcR7YvuRztTiJkUrBo1j0/D2r/75WJlYdYJ KTDJNJrH3h5ifKO8f2uVqCtiD7LF0bZNvJ1V7X8SPStt9Tx5NtCA1YLyngHZrJfyoJ FhdjgYNlypD/gYrgukRTZThhdJESeExBQGjNa7Vk= Date: Mon, 13 Apr 2020 14:25:30 +0300 From: Leon Romanovsky To: Jose Abreu Cc: "David S. Miller" , Jakub Kicinski , Arjan van de Ven , Cong Wang , Jamal Hadi Salim , Jiri Pirko , "netdev@vger.kernel.org" Subject: Re: [PATCH net v1] net/sched: Don't print dump stack in event of transmission timeout Message-ID: <20200413112530.GL334007@unreal> References: <20200412060854.334895-1-leon@kernel.org> <20200413102053.GI334007@unreal> <20200413105408.GJ334007@unreal> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Apr 13, 2020 at 11:01:42AM +0000, Jose Abreu wrote: > From: Leon Romanovsky > Date: Apr/13/2020, 11:54:08 (UTC+00:00) > > > Sorry, if I misunderstood you, but you are proposing to count traffic, right? > > > > If yes, RDMA traffic bypasses the SW stack and not visible to the kernel, hence > > the BQL will count only ETH portion of that mixed traffic, while RDMA traffic > > is the one who "blocked" transmission channel (QP in RDMA terminology). > > Sorry but you don't mention in your commit message that this is RDMA > specific so that's why I brought up the topic of BQL. Apologies for the > misunderstood. No problem, I'm glad that you asked those questions, hope that my answers clear the rationale behind change from WARN_ON to be pr_err(). Thanks > > --- > Thanks, > Jose Miguel Abreu