From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69C83C2BB55 for ; Fri, 17 Apr 2020 08:25:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 48514221E9 for ; Fri, 17 Apr 2020 08:25:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587111959; bh=fK/cXiYShdspx23uIMbNjC7y/u6N+6cfwWHvoDHM2e4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=doyVJL3Ivt5ktG3vCx05scTfSKH2mUp+Y8Z3/vQlNdj9DOEve59q/ZeWUqnKjuyha 4yyV+oz4jFtPPEZLhAr8m0m4PvEKavXZWU/r/HB7eUHMpT2GKPyN5M5jWfa0GiGrh4 fUUp5UwrhRIejniw8C8Dl0epO630Wjw7u7RUmpxo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729694AbgDQIZ6 (ORCPT ); Fri, 17 Apr 2020 04:25:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:56160 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729166AbgDQIZ6 (ORCPT ); Fri, 17 Apr 2020 04:25:58 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7F94C207FC; Fri, 17 Apr 2020 08:25:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587111958; bh=fK/cXiYShdspx23uIMbNjC7y/u6N+6cfwWHvoDHM2e4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DCAbhgwue3ZLmVb8MV6QQ8lqfJm+5ZU4+vFl2rnTKJLniAByGIE8N5d5EeehJhHqB TzQtN5tB0leny2fS8bCR1574WzlOUQm340Twh7YSJ+O/clEmzKiotPbinBfiTKweAa gKwPDfOzuj2SP1cu8NTwZaelNQ53Qpf7EsSrH/+Q= Date: Fri, 17 Apr 2020 10:25:55 +0200 From: "gregkh@linuxfoundation.org" To: Saeed Mahameed Cc: "kuba@kernel.org" , "sashal@kernel.org" , "ecree@solarflare.com" , "stable@vger.kernel.org" , "netdev@vger.kernel.org" , "davem@davemloft.net" , "gerlitz.or@gmail.com" Subject: Re: [PATCH AUTOSEL 4.9 09/26] net/mlx5e: Init ethtool steering for representors Message-ID: <20200417082555.GA140064@kroah.com> References: <20200414205755.GF1068@sasha-vm> <41174e71-00e1-aebf-b67d-1b24731e4ab3@solarflare.com> <20200416000009.GL1068@sasha-vm> <20200416172001.GC1388618@kroah.com> <20200416130828.1f35b6cf@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <4a5bc4cf3225682e3d79590eeec1ae81774e3c2a.camel@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4a5bc4cf3225682e3d79590eeec1ae81774e3c2a.camel@mellanox.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Apr 16, 2020 at 09:11:38PM +0000, Saeed Mahameed wrote: > On Thu, 2020-04-16 at 13:08 -0700, Jakub Kicinski wrote: > > On Thu, 16 Apr 2020 19:31:25 +0000 Saeed Mahameed wrote: > > > > > IMHO it doesn't make any sense to take into stable > > > > > automatically > > > > > any patch that doesn't have fixes line. Do you have 1/2/3/4/5 > > > > > concrete > > > > > examples from your (referring to your Microsoft employee hat > > > > > comment > > > > > below) or other's people production environment where patches > > > > > proved to > > > > > be necessary but they lacked the fixes tag - would love to see > > > > > them. > > > > > > > > Oh wow, where do you want me to start. I have zillions of these. > > > > > > > > But wait, don't trust me, trust a 3rd party. Here's what > > > > Google's > > > > security team said about the last 9 months of 2019: > > > > - 209 known vulnerabilities patched in LTS kernels, most > > > > without > > > > CVEs > > > > - 950+ criticial non-security bugs fixes for device XXXX alone > > > > with LTS releases > > > > > > So opt-in for these critical or _always_ in use basic kernel > > > sections. > > > but make the default opt-out.. > > > > But the less attentive/weaker the maintainers the more benefit from > > autosel they get. The default has to be correct for the group which > > is more likely to take no action. > > or the more exposed they are to false positives :), unnoticed bugs due > to wrong patches getting backported.. this could go for years for less > attentive weaker modules, until someone steps on it. Bugs due to only a limited set of patches being backported are generally very rare compared to the known bugs being present that are not fixed by not backporting patches. Play the odds, they are not in your favor at the moment :) thanks, greg k-h