From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0C92C38A2B for ; Fri, 17 Apr 2020 19:34:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AB44F206D9 for ; Fri, 17 Apr 2020 19:34:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587152067; bh=cgTuU2wq4VHHMob0ArleEq1p95SpnlUXFK7duK8u4Hs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=kE/mh7PyBWkovrOeXrpbtYJTM8jdSCI07qcfpYU4C1LsJ77p6HVnP5B5fNBSQ1HZo fE7KugXZ8qHTTUHN+7AWToWQhZOzvWmdQIOO5lM1K3mTUoNAwDFlV33I3CuM0e/0P8 DwxOjZTAX9FzgooAgcQEibi5qqKCxt2QwUGzZFQw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730411AbgDQTe0 (ORCPT ); Fri, 17 Apr 2020 15:34:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:44866 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728826AbgDQTe0 (ORCPT ); Fri, 17 Apr 2020 15:34:26 -0400 Received: from localhost (unknown [213.57.247.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 47803206B9; Fri, 17 Apr 2020 19:34:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587152066; bh=cgTuU2wq4VHHMob0ArleEq1p95SpnlUXFK7duK8u4Hs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=zqVxr4ILCmq1pKp/UpPNhgwbYVAPoEpxsmbVcRTYk/Hl+5lWEBWcQHdDlnFwyWZE6 zDz2yZ9knh0CRBlxgJ1N4T7bkwypzAHLo9DwTT2ja4CY1OPElA4g7H7DXF8mkPm1k0 rLzih/cyKZr67zoOV826m1xwqqrxIOAmysu+rfJQ= Date: Fri, 17 Apr 2020 22:34:21 +0300 From: Leon Romanovsky To: Jeff Kirsher Cc: gregkh@linuxfoundation.org, jgg@ziepe.ca, Mustafa Ismail , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com, Shiraz Saleem Subject: Re: [RFC PATCH v5 01/16] RDMA/irdma: Add driver framework definitions Message-ID: <20200417193421.GB3083@unreal> References: <20200417171251.1533371-1-jeffrey.t.kirsher@intel.com> <20200417171251.1533371-2-jeffrey.t.kirsher@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200417171251.1533371-2-jeffrey.t.kirsher@intel.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Apr 17, 2020 at 10:12:36AM -0700, Jeff Kirsher wrote: > From: Mustafa Ismail > > Register irdma as a virtbus driver capable of supporting virtbus > devices from multi-generation RDMA capable Intel HW. Establish the > interface with all supported netdev peer drivers and initialize HW. > > Signed-off-by: Mustafa Ismail > Signed-off-by: Shiraz Saleem > --- > drivers/infiniband/hw/irdma/i40iw_if.c | 228 ++++++++++ > drivers/infiniband/hw/irdma/irdma_if.c | 449 ++++++++++++++++++ > drivers/infiniband/hw/irdma/main.c | 573 +++++++++++++++++++++++ > drivers/infiniband/hw/irdma/main.h | 599 +++++++++++++++++++++++++ > 4 files changed, 1849 insertions(+) > create mode 100644 drivers/infiniband/hw/irdma/i40iw_if.c > create mode 100644 drivers/infiniband/hw/irdma/irdma_if.c > create mode 100644 drivers/infiniband/hw/irdma/main.c > create mode 100644 drivers/infiniband/hw/irdma/main.h > I didn't look in too much details, but three things caught my attention immediately: 1. Existence of ARP cache management logic in RDMA driver. 2. Extensive use of dev_*() prints while we have ibdev_*() prints 3. Extra includes (moduleparam.h ???). Thanks