From: David Miller <davem@davemloft.net>
To: andre.guedes@linux.intel.com
Cc: jeffrey.t.kirsher@intel.com, kuba@kernel.org,
andre.guedes@intel.com, netdev@vger.kernel.org,
nhorman@redhat.com, sassmann@redhat.com, aaron.f.brown@intel.com
Subject: Re: [net-next 02/13] igc: Use netdev log helpers in igc_main.c
Date: Tue, 21 Apr 2020 15:32:21 -0700 (PDT) [thread overview]
Message-ID: <20200421.153221.2089591404052111123.davem@davemloft.net> (raw)
In-Reply-To: <158750338551.60047.10607495842380954746@pvrobles-mobl1.amr.corp.intel.com>
From: Andre Guedes <andre.guedes@linux.intel.com>
Date: Tue, 21 Apr 2020 14:09:45 -0700
> Quoting David Miller (2020-04-21 12:26:10)
>> I'm tossing this series, you have to explain where this happens
>> because I see several developers who can't figure this out at all.
>
> Hope that clarifies and this series is still good to be merged.
First of all, the commits make it look like specifically like the
netdev printk facilities do the newline thing.
But overall this looks like just busy work, and I've seen commits
that add missing newlines.
I don't think these changes are valuable nor wise.
Please kill these newline removal changes, thank you.
next prev parent reply other threads:[~2020-04-21 22:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-20 23:43 [net-next 00/13][pull request] 1GbE Intel Wired LAN Driver Updates 2020-04-20 Jeff Kirsher
2020-04-20 23:43 ` [net-next 01/13] igc: Add ECN support for TSO Jeff Kirsher
2020-04-20 23:43 ` [net-next 02/13] igc: Use netdev log helpers in igc_main.c Jeff Kirsher
2020-04-21 17:39 ` Jakub Kicinski
2020-04-21 19:26 ` David Miller
2020-04-21 21:09 ` Andre Guedes
2020-04-21 22:32 ` David Miller [this message]
2020-04-21 22:48 ` Andre Guedes
2020-04-20 23:43 ` [net-next 03/13] igc: add support to interrupt, eeprom, registers and link self-tests Jeff Kirsher
2020-04-21 17:48 ` Jakub Kicinski
2020-04-20 23:43 ` [net-next 04/13] igc: Use netdev log helpers in igc_ethtool.c Jeff Kirsher
2020-04-20 23:43 ` [net-next 05/13] igc: Use netdev log helpers in igc_ptp.c Jeff Kirsher
2020-04-20 23:43 ` [net-next 06/13] igc: Use netdev log helpers in igc_dump.c Jeff Kirsher
2020-04-20 23:43 ` [net-next 07/13] igc: Use netdev log helpers in igc_base.c Jeff Kirsher
2020-04-20 23:43 ` [net-next 08/13] igc: Remove '\n' from log strings in igc_i225.c Jeff Kirsher
2020-04-20 23:43 ` [net-next 09/13] igc: Remove '\n' from log strings in igc_mac.c Jeff Kirsher
2020-04-20 23:43 ` [net-next 10/13] igc: Remove '\n' from log messages in igc_nvm.c Jeff Kirsher
2020-04-20 23:43 ` [net-next 11/13] igc: Remove '\n' from log strings in igc_phy.c Jeff Kirsher
2020-04-20 23:43 ` [net-next 12/13] igc: Remove unneeded definition Jeff Kirsher
2020-04-20 23:43 ` [net-next 13/13] igc: Remove unneeded register Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200421.153221.2089591404052111123.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=aaron.f.brown@intel.com \
--cc=andre.guedes@intel.com \
--cc=andre.guedes@linux.intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).