From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31C45C54FD0 for ; Thu, 23 Apr 2020 22:53:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1BD3A2051A for ; Thu, 23 Apr 2020 22:53:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727884AbgDWWxa (ORCPT ); Thu, 23 Apr 2020 18:53:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38046 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726057AbgDWWxa (ORCPT ); Thu, 23 Apr 2020 18:53:30 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B38F4C09B042; Thu, 23 Apr 2020 15:53:30 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id CFC0C127E67A7; Thu, 23 Apr 2020 15:53:29 -0700 (PDT) Date: Thu, 23 Apr 2020 15:53:29 -0700 (PDT) Message-Id: <20200423.155329.1710757370582804428.davem@davemloft.net> To: vee.khee.wong@intel.com Cc: peppe.cavallaro@st.com, alexandre.torgue@st.com, joabreu@synopsys.com, mcoquelin.stm32@gmail.com, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, boon.leong.ong@intel.com, weifeng.voon@intel.com Subject: Re: [PATCH net-next 1/1] net: stmmac: Add option for VLAN filter fail queue enable From: David Miller In-Reply-To: <20200423070026.26200-1-vee.khee.wong@intel.com> References: <20200423070026.26200-1-vee.khee.wong@intel.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 23 Apr 2020 15:53:30 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Wong Vee Khee Date: Thu, 23 Apr 2020 15:00:26 +0800 > From: "Chuah, Kim Tatt" > > Add option in plat_stmmacenet_data struct to enable VLAN Filter Fail > Queuing. This option allows packets that fail VLAN filter to be routed > to a specific Rx queue when Receive All is also set. > > When this option is enabled: > - Enable VFFQ only when entering promiscuous mode, because Receive All > will pass up all rx packets that failed address filtering (similar to > promiscuous mode). > - VLAN-promiscuous mode is never entered to allow rx packet to fail VLAN > filters and get routed to selected VFFQ Rx queue. > > Reviewed-by: Voon Weifeng > Reviewed-by: Ong Boon Leong > Signed-off-by: Chuah, Kim Tatt > Signed-off-by: Ong Boon Leong Why would you be setting this with a platform attribute? Even if the capability exists, wouldn't you want the user to be able to choose to opt out?