netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: dmurphy@ti.com
Cc: andrew@lunn.ch, f.fainelli@gmail.com, hkallweit1@gmail.com,
	linux@armlinux.org.uk, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org, afd@ti.com
Subject: Re: [PATCH net v2 2/2] net: phy: DP83TC811: Fix WoL in config init to be disabled
Date: Tue, 28 Apr 2020 13:05:45 -0700 (PDT)	[thread overview]
Message-ID: <20200428.130545.1878103691480474686.davem@davemloft.net> (raw)
In-Reply-To: <20200427212112.25368-3-dmurphy@ti.com>

From: Dan Murphy <dmurphy@ti.com>
Date: Mon, 27 Apr 2020 16:21:12 -0500

> +		return phy_write_mmd(phydev, DP83822_DEVADDR,
                                             ^^^^^^^^^^^^^^^^

Please don't submit patches that have not even had a conversation with
the compiler.

This register define only exists in dp83822.c and you are trying to use
it in dp83tc811.c

If this doesn't compile, how did you do functional testing of this
change?

If you compile tested these changes against a tree other than the 'net'
tree, please don't do that.

Thanks.

  parent reply	other threads:[~2020-04-28 20:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-27 21:21 [PATCH net v2 0/2] WoL fixes for DP83822 and DP83tc811 Dan Murphy
2020-04-27 21:21 ` [PATCH net v2 1/2] net: phy: DP83822: Fix WoL in config init to be disabled Dan Murphy
2020-04-27 21:21 ` [PATCH net v2 2/2] net: phy: DP83TC811: " Dan Murphy
2020-04-28 15:07   ` kbuild test robot
2020-04-28 20:05   ` David Miller [this message]
2020-04-28 20:59     ` Dan Murphy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200428.130545.1878103691480474686.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=afd@ti.com \
    --cc=andrew@lunn.ch \
    --cc=dmurphy@ti.com \
    --cc=f.fainelli@gmail.com \
    --cc=hkallweit1@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).