From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8209C83001 for ; Tue, 28 Apr 2020 00:06:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C670B2087E for ; Tue, 28 Apr 2020 00:06:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726422AbgD1AGp (ORCPT ); Mon, 27 Apr 2020 20:06:45 -0400 Received: from correo.us.es ([193.147.175.20]:59428 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726348AbgD1AGo (ORCPT ); Mon, 27 Apr 2020 20:06:44 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 22C42E16EF for ; Tue, 28 Apr 2020 02:06:43 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 166352DC71 for ; Tue, 28 Apr 2020 02:06:43 +0200 (CEST) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id 0BD20BAABA; Tue, 28 Apr 2020 02:06:43 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 16991DA736; Tue, 28 Apr 2020 02:06:41 +0200 (CEST) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Tue, 28 Apr 2020 02:06:41 +0200 (CEST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (unknown [90.77.255.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id ECADE42EF9E0; Tue, 28 Apr 2020 02:06:40 +0200 (CEST) Date: Tue, 28 Apr 2020 02:06:40 +0200 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Maciej =?utf-8?Q?=C5=BBenczykowski?= Cc: Maciej =?utf-8?Q?=C5=BBenczykowski?= , Florian Westphal , Linux Network Development Mailing List , Netfilter Development Mailing List Subject: Re: [PATCH] do not typedef socklen_t on Android Message-ID: <20200428000640.GE24002@salvia> References: <20200421081549.108375-1-zenczykowski@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200421081549.108375-1-zenczykowski@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Virus-Scanned: ClamAV using ClamSMTP Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Apr 21, 2020 at 01:15:49AM -0700, Maciej Żenczykowski wrote: > From: Maciej Żenczykowski > > This is present in bionic header files regardless of compiler > being used (likely clang) > > Test: builds > Signed-off-by: Maciej Żenczykowski > --- > libiptc/libip4tc.c | 2 +- > libiptc/libip6tc.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libiptc/libip4tc.c b/libiptc/libip4tc.c > index 55540638..08147055 100644 > --- a/libiptc/libip4tc.c > +++ b/libiptc/libip4tc.c > @@ -22,7 +22,7 @@ > #define inline > #endif > > -#if !defined(__GLIBC__) || (__GLIBC__ < 2) > +#if !defined(__ANDROID__) && (!defined(__GLIBC__) || (__GLIBC__ < 2)) Out of curiosity: Is there documentation on this Android libc library and how this definition is used? Thank you.