From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB73BC83001 for ; Tue, 28 Apr 2020 15:47:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A9F36206C0 for ; Tue, 28 Apr 2020 15:47:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="KUdP9lUE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728217AbgD1Pre (ORCPT ); Tue, 28 Apr 2020 11:47:34 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:57318 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728035AbgD1Pre (ORCPT ); Tue, 28 Apr 2020 11:47:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=WuBNSxGz0GAmdJ8bMObcwhw4PUFEzUK2Rx0IAHo9GwA=; b=KUdP9lUEvZWpYNnf4gpCxQrjxL 2xH8Gclat6ibocZijiMObC1+i2iI/Waq+sXPcO8SG5f4XFaSu9L7zA/Rh+/dm44IfbvVTDu5YcfZL E5Iw5aD9fT4CozKPlwz/6SbIBf6WWRtdlLZtGHzuN+8NSAtBlZ/L4DFGWV4RLBWOkxQg=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1jTSS6-0006ry-5F; Tue, 28 Apr 2020 17:47:18 +0200 Date: Tue, 28 Apr 2020 17:47:18 +0200 From: Andrew Lunn To: Geert Uytterhoeven Cc: Oleksij Rempel , Florian Fainelli , Heiner Kallweit , David Jander , "David S. Miller" , Sascha Hauer , Linux Kernel Mailing List , netdev , Philippe Schenker , Russell King , Sergei Shtylyov , Linux-Renesas Subject: Re: [PATCH net-next v3] net: phy: micrel: add phy-mode support for the KSZ9031 PHY Message-ID: <20200428154718.GA24923@lunn.ch> References: <20200422072137.8517-1-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Apr 28, 2020 at 05:28:30PM +0200, Geert Uytterhoeven wrote: > This triggers on Renesas Salvator-X(S): > > Micrel KSZ9031 Gigabit PHY e6800000.ethernet-ffffffff:00: > *-skew-ps values should be used only with phy-mode = "rgmii" > > which uses: > > phy-mode = "rgmii-txid"; > > and: > > rxc-skew-ps = <1500>; > > If I understand Documentation/devicetree/bindings/net/ethernet-controller.yaml > correctly: Hi Geert Checking for skews which might contradict the PHY-mode is new. I think this is the first PHY driver to do it. So i'm not too surprised it has triggered a warning, or there is contradictory documentation. Your use cases is reasonable. Have the normal transmit delay, and a bit shorted receive delay. So we should allow it. It just makes the validation code more complex :-( Andrew