From: Oleksij Rempel <o.rempel@pengutronix.de>
To: Rob Herring <robh+dt@kernel.org>,
"David S. Miller" <davem@davemloft.net>
Cc: Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Mark Rutland <mark.rutland@arm.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
netdev <netdev@vger.kernel.org>, Marek Vasut <marex@denx.de>,
David Jander <david@protonic.nl>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v4 1/4] dt-bindings: net: phy: Add support for NXP TJA11xx
Date: Wed, 29 Apr 2020 06:38:08 +0200 [thread overview]
Message-ID: <20200429043808.jdlhoeuujfxdifh7@pengutronix.de> (raw)
In-Reply-To: <CAL_JsqJgwKjWnTETB1pDc+aXVYp0c-cYOE6gz_KYOn5byQOKpA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 3678 bytes --]
@Rob, thank you for the review.
@David, should I send fixes or reworked initial patches?
On Tue, Apr 28, 2020 at 12:30:06PM -0500, Rob Herring wrote:
> On Fri, Mar 13, 2020 at 12:23 AM Oleksij Rempel <o.rempel@pengutronix.de> wrote:
> >
> > Document the NXP TJA11xx PHY bindings.
>
> Given the discussion, I'd marked this one as "changes requested"
> expecting a new version to review the schema. And gmail decided to
> make a new thread due to the extra 'RE:'. So it fell off my radar.
>
> This schema is fundamentally broken as there's no way to match for
> when to apply this schema. How do we find a NXP TJA11xx PHY? I suppose
> we can look for 'ethernet-phy' with a child node 'ethernet-phy', but
> then that would apply to any phy like this one. This needs a
> compatible string IMO given it is non-standard.
>
> >
> > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> > ---
> > .../devicetree/bindings/net/nxp,tja11xx.yaml | 61 +++++++++++++++++++
> > 1 file changed, 61 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/net/nxp,tja11xx.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/net/nxp,tja11xx.yaml b/Documentation/devicetree/bindings/net/nxp,tja11xx.yaml
> > new file mode 100644
> > index 000000000000..42be0255512b
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/net/nxp,tja11xx.yaml
> > @@ -0,0 +1,61 @@
> > +# SPDX-License-Identifier: GPL-2.0+
>
> Dual license new bindings:
>
> (GPL-2.0-only OR BSD-2-Clause)
>
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/net/nxp,tja11xx.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: NXP TJA11xx PHY
> > +
> > +maintainers:
> > + - Andrew Lunn <andrew@lunn.ch>
> > + - Florian Fainelli <f.fainelli@gmail.com>
> > + - Heiner Kallweit <hkallweit1@gmail.com>
> > +
> > +description:
> > + Bindings for NXP TJA11xx automotive PHYs
>
> Perhaps some information about how this phy is special.
>
> > +
> > +allOf:
> > + - $ref: ethernet-phy.yaml#
>
> Not needed here as ethernet-phy.yaml already has a 'select' condition to apply.
>
> > +
> > +patternProperties:
> > + "^ethernet-phy@[0-9a-f]+$":
> > + type: object
> > + description: |
> > + Some packages have multiple PHYs. Secondary PHY should be defines as
> > + subnode of the first (parent) PHY.
> > +
> > + properties:
> > + reg:
> > + minimum: 0
> > + maximum: 31
> > + description:
> > + The ID number for the child PHY. Should be +1 of parent PHY.
> > +
> > + required:
> > + - reg
> > +
> > +examples:
> > + - |
> > + mdio {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + tja1101_phy0: ethernet-phy@4 {
> > + reg = <0x4>;
> > + };
> > + };
> > + - |
> > + mdio {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + tja1102_phy0: ethernet-phy@4 {
> > + reg = <0x4>;
>
> > + #address-cells = <1>;
> > + #size-cells = <0>;
>
> These aren't documented.
>
> > +
> > + tja1102_phy1: ethernet-phy@5 {
> > + reg = <0x5>;
> > + };
> > + };
> > + };
> > --
> > 2.25.1
> >
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-04-29 4:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 5:22 [PATCH v4 0/4] add TJA1102 support Oleksij Rempel
2020-03-13 5:22 ` [PATCH v4 1/4] dt-bindings: net: phy: Add support for NXP TJA11xx Oleksij Rempel
2020-03-13 18:02 ` Florian Fainelli
2020-03-13 18:10 ` Andrew Lunn
2020-03-13 18:16 ` Oleksij Rempel
2020-03-13 18:20 ` Florian Fainelli
2020-03-13 18:53 ` Oleksij Rempel
2020-03-17 11:56 ` Oleksij Rempel
2020-03-17 19:48 ` Florian Fainelli
2020-03-20 23:05 ` Rob Herring
2020-03-22 21:09 ` Florian Fainelli
2020-03-23 14:20 ` Rob Herring
2020-04-28 17:30 ` Rob Herring
2020-04-29 4:38 ` Oleksij Rempel [this message]
2020-04-29 4:45 ` Florian Fainelli
2020-03-13 5:22 ` [PATCH v4 2/4] net: phy: tja11xx: add initial TJA1102 support Oleksij Rempel
2020-03-13 5:22 ` [PATCH v4 3/4] net: mdio: of: export part of of_mdiobus_register_phy() Oleksij Rempel
2020-03-13 5:22 ` [PATCH v4 4/4] net: phy: tja11xx: add delayed registration of TJA1102 PHY1 Oleksij Rempel
2020-03-16 8:44 ` [PATCH v4 0/4] add TJA1102 support David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200429043808.jdlhoeuujfxdifh7@pengutronix.de \
--to=o.rempel@pengutronix.de \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=david@protonic.nl \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).