From: Joyce Ooi <joyce.ooi@intel.com>
To: Thor Thayer <thor.thayer@linux.intel.com>,
"David S . Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Dalon Westergreen <dalon.westergreen@intel.com>,
Joyce Ooi <joyce.ooi@intel.com>,
Tan Ley Foon <ley.foon.tan@intel.com>,
See Chin Liang <chin.liang.see@intel.com>,
Dinh Nguyen <dinh.nguyen@intel.com>
Subject: [PATCHv2 03/10] net: eth: altera: fix altera_dmaops declaration
Date: Mon, 4 May 2020 16:25:51 +0800 [thread overview]
Message-ID: <20200504082558.112627-4-joyce.ooi@intel.com> (raw)
In-Reply-To: <20200504082558.112627-1-joyce.ooi@intel.com>
From: Dalon Westergreen <dalon.westergreen@intel.com>
The declaration of struct altera_dmaops does not have
identifier names. Add identifier names to confrom with
required coding styles.
Signed-off-by: Dalon Westergreen <dalon.westergreen@intel.com>
Signed-off-by: Joyce Ooi <joyce.ooi@intel.com>
---
v2: no change
---
drivers/net/ethernet/altera/altera_tse.h | 30 ++++++++++++++++--------------
1 file changed, 16 insertions(+), 14 deletions(-)
diff --git a/drivers/net/ethernet/altera/altera_tse.h b/drivers/net/ethernet/altera/altera_tse.h
index f17acfb579a0..7d0c98fc103e 100644
--- a/drivers/net/ethernet/altera/altera_tse.h
+++ b/drivers/net/ethernet/altera/altera_tse.h
@@ -385,20 +385,22 @@ struct altera_tse_private;
struct altera_dmaops {
int altera_dtype;
int dmamask;
- void (*reset_dma)(struct altera_tse_private *);
- void (*enable_txirq)(struct altera_tse_private *);
- void (*enable_rxirq)(struct altera_tse_private *);
- void (*disable_txirq)(struct altera_tse_private *);
- void (*disable_rxirq)(struct altera_tse_private *);
- void (*clear_txirq)(struct altera_tse_private *);
- void (*clear_rxirq)(struct altera_tse_private *);
- int (*tx_buffer)(struct altera_tse_private *, struct tse_buffer *);
- u32 (*tx_completions)(struct altera_tse_private *);
- void (*add_rx_desc)(struct altera_tse_private *, struct tse_buffer *);
- u32 (*get_rx_status)(struct altera_tse_private *);
- int (*init_dma)(struct altera_tse_private *);
- void (*uninit_dma)(struct altera_tse_private *);
- void (*start_rxdma)(struct altera_tse_private *);
+ void (*reset_dma)(struct altera_tse_private *priv);
+ void (*enable_txirq)(struct altera_tse_private *priv);
+ void (*enable_rxirq)(struct altera_tse_private *priv);
+ void (*disable_txirq)(struct altera_tse_private *priv);
+ void (*disable_rxirq)(struct altera_tse_private *priv);
+ void (*clear_txirq)(struct altera_tse_private *priv);
+ void (*clear_rxirq)(struct altera_tse_private *priv);
+ int (*tx_buffer)(struct altera_tse_private *priv,
+ struct tse_buffer *buffer);
+ u32 (*tx_completions)(struct altera_tse_private *priv);
+ void (*add_rx_desc)(struct altera_tse_private *priv,
+ struct tse_buffer *buffer);
+ u32 (*get_rx_status)(struct altera_tse_private *priv);
+ int (*init_dma)(struct altera_tse_private *priv);
+ void (*uninit_dma)(struct altera_tse_private *priv);
+ void (*start_rxdma)(struct altera_tse_private *priv);
};
/* This structure is private to each device.
--
2.13.0
next prev parent reply other threads:[~2020-05-04 8:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-04 8:25 [PATCHv2 00/10] net: eth: altera: tse: Add PTP and mSGDMA prefetcher Joyce Ooi
2020-05-04 8:25 ` [PATCHv2 01/10] net: eth: altera: tse_start_xmit ignores tx_buffer call response Joyce Ooi
2020-05-04 17:39 ` David Miller
2020-05-05 9:27 ` Ooi, Joyce
2020-05-04 8:25 ` [PATCHv2 02/10] net: eth: altera: set rx and tx ring size before init_dma call Joyce Ooi
2020-05-04 8:25 ` Joyce Ooi [this message]
2020-05-04 8:25 ` [PATCHv2 04/10] net: eth: altera: add optional function to start tx dma Joyce Ooi
2020-05-04 8:25 ` [PATCHv2 05/10] net: eth: altera: Move common functions to altera_utils Joyce Ooi
2020-05-04 8:25 ` [PATCHv2 06/10] net: eth: altera: Add missing identifier names to function declarations Joyce Ooi
2020-05-04 8:25 ` [PATCHv2 07/10] net: eth: altera: change tx functions to type netdev_tx_t Joyce Ooi
2020-05-04 8:25 ` [PATCHv2 08/10] net: eth: altera: add support for ptp and timestamping Joyce Ooi
2020-05-04 16:52 ` Richard Cochran
2020-05-04 8:25 ` [PATCHv2 09/10] net: eth: altera: add msgdma prefetcher Joyce Ooi
2020-05-04 8:25 ` [PATCHv2 10/10] net: eth: altera: update devicetree bindings documentation Joyce Ooi
2020-05-12 22:52 ` Rob Herring
2020-05-13 12:00 ` Ooi, Joyce
2020-05-13 13:00 ` Ooi, Joyce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200504082558.112627-4-joyce.ooi@intel.com \
--to=joyce.ooi@intel.com \
--cc=chin.liang.see@intel.com \
--cc=dalon.westergreen@intel.com \
--cc=davem@davemloft.net \
--cc=dinh.nguyen@intel.com \
--cc=ley.foon.tan@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=thor.thayer@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).