From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A228EC47255 for ; Mon, 11 May 2020 22:36:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7DABE20736 for ; Mon, 11 May 2020 22:36:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589236599; bh=gHLiG+DSLpLJo5lP1j6NEzFrYlzPvs0mBsoXQjlJQKM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=tWxypwd6FhFnbWTi5aPJTU7VZNa1YX/Suj/DiU2Jjm9MOF2eRQP07hwRkA72J+VK1 NHASrka3JCfasRSVx+sEt9xS0C79tkqUNEIEavZU2G34eKXVejhZn8QpugY8VMrERB VFNSF8qBRw2u+TE3OCdEm/QzIEjxDPFD040kmaHw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727830AbgEKWgi (ORCPT ); Mon, 11 May 2020 18:36:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:40224 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725828AbgEKWgi (ORCPT ); Mon, 11 May 2020 18:36:38 -0400 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C83DB2070B; Mon, 11 May 2020 22:36:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589236598; bh=gHLiG+DSLpLJo5lP1j6NEzFrYlzPvs0mBsoXQjlJQKM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=zSeY9A+9wzXoyuDeogs28ZxENZR2AAGE831pLipTv5CSBQNvCV3NAns1pNXM4V+63 lrXwFnT6wMA+TtaZmt6m5mBrH8e/vnMlh7ThSaKIpJODVWbbrOgfGyvbIZgnGHDguw Uj19zogPrr7g++kSOyaRNCCB6Q/J9ItsG8GIehOc= Date: Mon, 11 May 2020 15:36:36 -0700 From: Jakub Kicinski To: Edward Cree Cc: , , Subject: Re: [PATCH net-next 2/8] sfc: make capability checking a nic_type function Message-ID: <20200511153636.0f9cd385@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: References: <8154dba6-b312-7dcf-7d49-cd6c6801ffc2@solarflare.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 11 May 2020 13:28:40 +0100 Edward Cree wrote: > From: Tom Zhao >=20 > Various MCDI functions (especially in filter handling) need to check the > datapath caps, but those live in nic_data (since they don't exist on > Siena). Decouple from ef10-specific data structures by adding check_caps > to the nic_type, to allow using these functions from non-ef10 drivers. >=20 > Also add a convenience macro efx_has_cap() to reduce the amount of > boilerplate involved in calling it. >=20 > Signed-off-by: Edward Cree Commit 66119f0b0358 ("sfc: make capability checking a nic_type function") author Signed-off-by missing author email: tzhao@solarflare.com committer email: kuba@kernel.org Signed-off-by: Edward Cree Errors in tree with Signed-off-by, please fix! Also with W=3D1: ../drivers/net/ethernet/sfc/siena.c:951:14: warning: symbol 'siena_check_c= aps' was not declared. Should it be static? 1a3,5 ../drivers/net/ethernet/sfc/siena.c:951:14: warning: no previous prototype= for =C3=A2=E2=82=AC=CB=9Csiena_check_caps=C3=A2=E2=82=AC=E2=84=A2 [-Wmissi= ng-prototypes] 951 | unsigned int siena_check_caps(const struct efx_nic *efx, | ^~~~~~~~~~~~~~~~