From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0353C433DF for ; Fri, 15 May 2020 19:41:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B246220728 for ; Fri, 15 May 2020 19:41:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589571662; bh=g8gec+6GS72iYCVcMDX9C9hbH7EqPvWA2ykcOJuzPKs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=HdiJU3qJB+sWJEmLaj36xvvSpZgdurxvIcXgVAb92gGtBPLIQ0zVn81f5+Tv1Twg2 M2E2gwQ0OEBtx+f0sEO/Iu7ICw8D+dyS77bZh87lupWsbImTqn1cpabGElywbdCxO9 MvVgnTJRqNMMT1XnwSLhOUSfjjBobrkv/ERTjh58= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726661AbgEOTlB (ORCPT ); Fri, 15 May 2020 15:41:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:45946 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726553AbgEOTlB (ORCPT ); Fri, 15 May 2020 15:41:01 -0400 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D897420709; Fri, 15 May 2020 19:41:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589571661; bh=g8gec+6GS72iYCVcMDX9C9hbH7EqPvWA2ykcOJuzPKs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ItY0j1UATmhdznCnGghz6pwc9I7QS7Ev3aRIRqr1Y2QtcHkZLeEvxoPXG2/n5HEvd NNzUYO7hQZJuWNkdBZyAsBaD2fWirQlGJUGZ20tmAIc4eJ8wC1ez+EmyPzVu5yXfd/ rx+83CqJygj/YR6Yi/k3bJ8eqfLzeYIYfLG9FDU4= Date: Fri, 15 May 2020 12:40:59 -0700 From: Jakub Kicinski To: Ioana Ciornei Cc: "davem@davemloft.net" , "netdev@vger.kernel.org" Subject: Re: [PATCH v2 net-next 0/7] dpaa2-eth: add support for Rx traffic classes Message-ID: <20200515124059.33c43d03@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: References: <20200515184753.15080-1-ioana.ciornei@nxp.com> <20200515122035.0b95eff4@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 15 May 2020 19:31:18 +0000 Ioana Ciornei wrote: > > Subject: Re: [PATCH v2 net-next 0/7] dpaa2-eth: add support for Rx traffic > > classes > > > > On Fri, 15 May 2020 21:47:46 +0300 Ioana Ciornei wrote: > > > This patch set adds support for Rx traffic classes on DPAA2 Ethernet > > > devices. > > > > > > The first two patches make the necessary changes so that multiple > > > traffic classes are configured and their statistics are displayed in > > > the debugfs. The third patch adds a static distribution to said > > > traffic classes based on the VLAN PCP field. > > > > > > The last patches add support for the congestion group taildrop > > > mechanism that allows us to control the number of frames that can > > > accumulate on a group of Rx frame queues belonging to the same traffic class. > > > > Ah, I miseed you already sent a v2. Same question applies: > > > > > How is this configured from the user perspective? I looked through the > > > patches and I see no information on how the input is taken from the > > > user. > > There is no input taken from the user at the moment. The traffic > class id is statically selected based on the VLAN PCP field. The > configuration for this is added in patch 3/7. Having some defaults for RX queue per TC is understandable. But patch 1 changes how many RX queues are used in the first place. Why if user does not need RX queues per TC?