From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FADAC433DF for ; Mon, 18 May 2020 16:33:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D59DC207ED for ; Mon, 18 May 2020 16:33:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589819592; bh=e1nutUo+bt/dwDVowCltfxhY9z//j/ZMRT5xFzOJLUU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=fUNnuvkFifPMtQtOlOYROC8Y0QmSg0qZ671iZArw8j/BT5hQV3Jx+VW7mpvEGQHDm 8zJC2VDs1mXadTlz3+Tp77IYU1kQCY0QgW0oHzQjOpGgJlBoYD/4k4L+OgwCoELxpF 3thOiWRZn+JhzSrSxOK2uCCAcsQ3WFqdDiaU+KzM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728204AbgERQdM (ORCPT ); Mon, 18 May 2020 12:33:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:32982 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727035AbgERQdL (ORCPT ); Mon, 18 May 2020 12:33:11 -0400 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 658C4207D8; Mon, 18 May 2020 16:33:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589819591; bh=e1nutUo+bt/dwDVowCltfxhY9z//j/ZMRT5xFzOJLUU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=BmWvNJRqfdhpBPwaCNDz/EPYcYhJ/UMz6fFMXu8U7Vd2b5zTAKkMruSIbABj3QRhU XXOl5gU9j/ULnkx3OJS03vHY0Ev/hjBdjFdzU0nz2eiMKfa8n/0Ra1YbDO1ZKUEYxZ SqaQKbp5P7E062+/dgtKpBsouO22VL2txHW48uHM= Date: Mon, 18 May 2020 09:33:09 -0700 From: Jakub Kicinski To: Marek Vasut Cc: netdev@vger.kernel.org, "David S . Miller" , Lukas Wunner , Petr Stetiar , YueHaibing Subject: Re: [PATCH V6 18/20] net: ks8851: Implement Parallel bus operations Message-ID: <20200518093309.5550c399@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20200517003354.233373-19-marex@denx.de> References: <20200517003354.233373-1-marex@denx.de> <20200517003354.233373-19-marex@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, 17 May 2020 02:33:52 +0200 Marek Vasut wrote: > Implement accessors for KS8851-16MLL/MLLI/MLLU parallel bus variant of > the KS8851. This is based off the ks8851_mll.c , which is a driver for > exactly the same hardware, however the ks8851.c code is much higher > quality. Hence, this patch pulls out the relevant information from the > ks8851_mll.c on how to access the bus, but uses the common ks8851.c > code. To make this patch reviewable, instead of rewriting ks8851_mll.c, > ks8851_mll.c is removed in a separate subsequent patch. > > Signed-off-by: Marek Vasut > Cc: David S. Miller > Cc: Lukas Wunner > Cc: Petr Stetiar > Cc: YueHaibing Please test build with W=1 drivers/net/ethernet/micrel/ks8851_par.c:64:13: warning: context imbalance in 'ks8851_lock_par' - wrong count at exit drivers/net/ethernet/micrel/ks8851_par.c:78:13: warning: context imbalance in 'ks8851_unlock_par' - unexpected unlock