From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A25CC433DF for ; Mon, 18 May 2020 16:34:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 75870207D8 for ; Mon, 18 May 2020 16:34:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589819665; bh=gMfwCxrgLc9Bc8pZCXEdHtlJ4uexDsK/SheKdw2OGrQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=k0XzS/VOc2mIu3WZvZR/Ht5KgnvBlbeGLDNaVxbrkWP+TgdHrdzBIrvCCNe8wOXIH 0/W3A53Mflj4OCdYLioKVv8olRaFmV5va63NFy1lkkBz5hHa+h86BPEcYWmtXZ4NTB uRqtt27rrFI9ofR0Idww12CQ9WBK6s6nrJV42YLk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728177AbgERQeY (ORCPT ); Mon, 18 May 2020 12:34:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:33398 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727020AbgERQeY (ORCPT ); Mon, 18 May 2020 12:34:24 -0400 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ADC9220709; Mon, 18 May 2020 16:34:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589819664; bh=gMfwCxrgLc9Bc8pZCXEdHtlJ4uexDsK/SheKdw2OGrQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=q7fZb/pl5NIzKPFh8OMQEkvDKRuATvahsKdrt8qXymP/8hIear4Eeeej+Sc88MsU+ SKv3N2/OEWUe6XHrHFjrcmpiD4yjqBcxyyI2nNRdbylsneO7ujW9IKbAhypC9CVOSR GpuMajPj8YBcMvKkyW03FFMmycosT7DYyiADR/Yw= Date: Mon, 18 May 2020 09:34:22 -0700 From: Jakub Kicinski To: Marek Vasut Cc: netdev@vger.kernel.org, Andrew Lunn , "David S . Miller" , Lukas Wunner , Petr Stetiar , YueHaibing Subject: Re: [PATCH V6 16/20] net: ks8851: Implement register, FIFO, lock accessor callbacks Message-ID: <20200518093422.38a52ca7@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20200517003354.233373-17-marex@denx.de> References: <20200517003354.233373-1-marex@denx.de> <20200517003354.233373-17-marex@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, 17 May 2020 02:33:50 +0200 Marek Vasut wrote: > The register and FIFO accessors are bus specific, so is locking. > Implement callbacks so that each variant of the KS8851 can implement > matching accessors and locking, and use the rest of the common code. > > Reviewed-by: Andrew Lunn > Signed-off-by: Marek Vasut > Cc: David S. Miller > Cc: Lukas Wunner > Cc: Petr Stetiar > Cc: YueHaibing drivers/net/ethernet/micrel/ks8851.c:138: warning: Function parameter or member '____cacheline_aligned' not described in 'ks8851_net' drivers/net/ethernet/micrel/ks8851.c:138: warning: Function parameter or member 'tx_space' not described in 'ks8851_net' drivers/net/ethernet/micrel/ks8851.c:138: warning: Function parameter or member 'lock' not described in 'ks8851_net' drivers/net/ethernet/micrel/ks8851.c:138: warning: Function parameter or member 'unlock' not described in 'ks8851_net' drivers/net/ethernet/micrel/ks8851.c:138: warning: Function parameter or member 'rdreg16' not described in 'ks8851_net' drivers/net/ethernet/micrel/ks8851.c:138: warning: Function parameter or member 'wrreg16' not described in 'ks8851_net' drivers/net/ethernet/micrel/ks8851.c:138: warning: Function parameter or member 'rdfifo' not described in 'ks8851_net' drivers/net/ethernet/micrel/ks8851.c:138: warning: Function parameter or member 'wrfifo' not described in 'ks8851_net' drivers/net/ethernet/micrel/ks8851.c:138: warning: Function parameter or member 'start_xmit' not described in 'ks8851_net' drivers/net/ethernet/micrel/ks8851.c:138: warning: Function parameter or member 'rx_skb' not described in 'ks8851_net' drivers/net/ethernet/micrel/ks8851.c:138: warning: Function parameter or member 'flush_tx_work' not described in 'ks8851_net' drivers/net/ethernet/micrel/ks8851.c:163: warning: Function parameter or member 'spi_xfer1' not described in 'ks8851_net_spi' drivers/net/ethernet/micrel/ks8851.c:163: warning: Function parameter or member 'spi_xfer2' not described in 'ks8851_net_spi' drivers/net/ethernet/micrel/ks8851.c:561: warning: Function parameter or member 'ks' not described in 'ks8851_rx_skb_spi' drivers/net/ethernet/micrel/ks8851.c:570: warning: Function parameter or member 'ks' not described in 'ks8851_rx_skb'