From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BC45C433E0 for ; Mon, 18 May 2020 17:29:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5CD3820829 for ; Mon, 18 May 2020 17:29:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589822986; bh=GbXVQnZpxLekbr4Sys/mEjkMWI6UHS1T656yS2bb/X0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=HlE5XwliJVL+gAsAHx3biLbYk8bYPP04qdqk6cN7cJrM3V76MLe4idLX/SGemjeNq 5ZkvR3msiZdmtpJwLjrDM1JokzWwpSA3SfY+EGCc8MnXymfaBWsO7yEWXiMVX/rwuc sKf4tS0BpPEoqP+S0G2zcCvm8KAJZDBOWIQ3iWqM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728395AbgERR3p (ORCPT ); Mon, 18 May 2020 13:29:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:57624 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726958AbgERR3p (ORCPT ); Mon, 18 May 2020 13:29:45 -0400 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 35A6E20715; Mon, 18 May 2020 17:29:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589822984; bh=GbXVQnZpxLekbr4Sys/mEjkMWI6UHS1T656yS2bb/X0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=mftvPHjdu02ZEoh0elInaEV+MZn8AWq6UqwXtOCCN9GDBWYEcNN3Ukr5HegRQomBs 4Io8aZAeFvrx8INCKRzKMhizd1JCNRXv7u+kqHeood9e1SWdemVNKDaMzYuZcAYFP3 Ernsfy58FoZX+ZJnF8DLU5mRWSEdL4YGAQIvVn0g= Date: Mon, 18 May 2020 10:29:42 -0700 From: Jakub Kicinski To: Marek Vasut Cc: netdev@vger.kernel.org, Andrew Lunn , "David S . Miller" , Lukas Wunner , Petr Stetiar , YueHaibing Subject: Re: [PATCH V6 16/20] net: ks8851: Implement register, FIFO, lock accessor callbacks Message-ID: <20200518102942.0d368e70@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: References: <20200517003354.233373-1-marex@denx.de> <20200517003354.233373-17-marex@denx.de> <20200518093422.38a52ca7@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 18 May 2020 19:06:45 +0200 Marek Vasut wrote: > On 5/18/20 6:34 PM, Jakub Kicinski wrote: > > On Sun, 17 May 2020 02:33:50 +0200 Marek Vasut wrote: > >> The register and FIFO accessors are bus specific, so is locking. > >> Implement callbacks so that each variant of the KS8851 can implement > >> matching accessors and locking, and use the rest of the common code. > >> > >> Reviewed-by: Andrew Lunn > >> Signed-off-by: Marek Vasut > >> Cc: David S. Miller > >> Cc: Lukas Wunner > >> Cc: Petr Stetiar > >> Cc: YueHaibing > > > > drivers/net/ethernet/micrel/ks8851.c:138: warning: Function parameter or member '____cacheline_aligned' not described in 'ks8851_net' > > drivers/net/ethernet/micrel/ks8851.c:138: warning: Function parameter or member 'tx_space' not described in 'ks8851_net' > > drivers/net/ethernet/micrel/ks8851.c:138: warning: Function parameter or member 'lock' not described in 'ks8851_net' > > drivers/net/ethernet/micrel/ks8851.c:138: warning: Function parameter or member 'unlock' not described in 'ks8851_net' > > drivers/net/ethernet/micrel/ks8851.c:138: warning: Function parameter or member 'rdreg16' not described in 'ks8851_net' > > drivers/net/ethernet/micrel/ks8851.c:138: warning: Function parameter or member 'wrreg16' not described in 'ks8851_net' > > drivers/net/ethernet/micrel/ks8851.c:138: warning: Function parameter or member 'rdfifo' not described in 'ks8851_net' > > drivers/net/ethernet/micrel/ks8851.c:138: warning: Function parameter or member 'wrfifo' not described in 'ks8851_net' > > drivers/net/ethernet/micrel/ks8851.c:138: warning: Function parameter or member 'start_xmit' not described in 'ks8851_net' > > drivers/net/ethernet/micrel/ks8851.c:138: warning: Function parameter or member 'rx_skb' not described in 'ks8851_net' > > drivers/net/ethernet/micrel/ks8851.c:138: warning: Function parameter or member 'flush_tx_work' not described in 'ks8851_net' > > drivers/net/ethernet/micrel/ks8851.c:163: warning: Function parameter or member 'spi_xfer1' not described in 'ks8851_net_spi' > > drivers/net/ethernet/micrel/ks8851.c:163: warning: Function parameter or member 'spi_xfer2' not described in 'ks8851_net_spi' > > drivers/net/ethernet/micrel/ks8851.c:561: warning: Function parameter or member 'ks' not described in 'ks8851_rx_skb_spi' > > drivers/net/ethernet/micrel/ks8851.c:570: warning: Function parameter or member 'ks' not described in 'ks8851_rx_skb' > > A lot of those were there already before this series I know, 4 out of the 15 above. > they are in fact fixed by this series. The result builds clean with W=1 . Excellent, fixing things is appreciated! It'd be great if new warnings did not intermittently exist mid-series.