From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37155C433E0 for ; Wed, 20 May 2020 15:57:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0931C20671 for ; Wed, 20 May 2020 15:57:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="RScn9hai" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726936AbgETP46 (ORCPT ); Wed, 20 May 2020 11:56:58 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:52872 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726856AbgETP45 (ORCPT ); Wed, 20 May 2020 11:56:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589990216; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Sno0GmQ/eQv+Rs74eF1UQLVprtgb41HhzSqFhBF9Z8s=; b=RScn9haiZyNpcqVRHR2LISRYxtfzc/yjpW5MALnYdN7PdzY5h5TJHqhxpdcClvWPcIYAdE Qs8QDbTTKz+LAVy48/4kK8k/i+B4Yp0DhLEtuOlRK1eNrgOtcJaDG4PgKWC6IrJsq1C0kZ 0koJdXL07hlnXmJZAaMzqcLMuLmNbNk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-30-sIzVUj7MM16DmhemM8TuYQ-1; Wed, 20 May 2020 11:56:52 -0400 X-MC-Unique: sIzVUj7MM16DmhemM8TuYQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CF91580183C; Wed, 20 May 2020 15:56:50 +0000 (UTC) Received: from ceranb (unknown [10.40.192.217]) by smtp.corp.redhat.com (Postfix) with ESMTP id ECE755D9CA; Wed, 20 May 2020 15:56:47 +0000 (UTC) Date: Wed, 20 May 2020 17:56:47 +0200 From: Ivan Vecera To: Horatiu Vultur Cc: , , , , , , , , , Subject: Re: [PATCH 2/3] switchdev: mrp: Remove the variable mrp_ring_state Message-ID: <20200520175647.32e6f5eb@ceranb> In-Reply-To: <20200520130923.3196432-3-horatiu.vultur@microchip.com> References: <20200520130923.3196432-1-horatiu.vultur@microchip.com> <20200520130923.3196432-3-horatiu.vultur@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 20 May 2020 13:09:22 +0000 Horatiu Vultur wrote: > Remove the variable mrp_ring_state from switchdev_attr because is not > used anywhere. > The ring state is set using SWITCHDEV_OBJ_ID_RING_STATE_MRP. > > Fixes: c284b5459008 ("switchdev: mrp: Extend switchdev API to offload MRP") > Signed-off-by: Horatiu Vultur > --- > include/net/switchdev.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/include/net/switchdev.h b/include/net/switchdev.h > index ae7aeb0d1f9ca..db519957e134b 100644 > --- a/include/net/switchdev.h > +++ b/include/net/switchdev.h > @@ -62,7 +62,6 @@ struct switchdev_attr { > #if IS_ENABLED(CONFIG_BRIDGE_MRP) > u8 mrp_port_state; /* MRP_PORT_STATE */ > u8 mrp_port_role; /* MRP_PORT_ROLE */ > - u8 mrp_ring_state; /* MRP_RING_STATE */ > #endif > } u; > }; Acked-by: Ivan Vecera