From: Jakub Kicinski <kuba@kernel.org>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: davem@davemloft.net, Andre Guedes <andre.guedes@intel.com>,
netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com,
Aaron Brown <aaron.f.brown@intel.com>
Subject: Re: [net-next 03/15] igc: Add support for source address filters in core
Date: Thu, 21 May 2020 09:23:23 -0700 [thread overview]
Message-ID: <20200521092323.70b8c9b6@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20200521072758.440264-4-jeffrey.t.kirsher@intel.com>
On Thu, 21 May 2020 00:27:46 -0700 Jeff Kirsher wrote:
> /**
> * igc_del_mac_filter() - Delete MAC address filter
> * @adapter: Pointer to adapter where the filter should be deleted from
> + * #type: MAC address filter type (source or destination)
@ here^ otherwise:
drivers/net/ethernet/intel/igc/igc_main.c:2282: warning: Function parameter or member 'type' not described in 'igc_del_mac_filter'
> * @addr: MAC address
> *
> * Return: 0 in case of success, negative errno code otherwise.
> */
> -int igc_del_mac_filter(struct igc_adapter *adapter, const u8 *addr)
> +int igc_del_mac_filter(struct igc_adapter *adapter,
> + enum igc_mac_filter_type type, const u8 *addr)
next prev parent reply other threads:[~2020-05-21 16:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-21 7:27 [net-next 00/15][pull request] 1GbE Intel Wired LAN Driver Updates 2020-05-20 Jeff Kirsher
2020-05-21 7:27 ` [net-next 01/15] igc: Remove IGC_MAC_STATE_SRC_ADDR flag Jeff Kirsher
2020-05-21 7:27 ` [net-next 02/15] igc: Remove mac_table from igc_adapter Jeff Kirsher
2020-05-21 7:27 ` [net-next 03/15] igc: Add support for source address filters in core Jeff Kirsher
2020-05-21 16:23 ` Jakub Kicinski [this message]
2020-05-21 22:46 ` Kirsher, Jeffrey T
2020-05-21 7:27 ` [net-next 04/15] igc: Enable NFC rules based source MAC address Jeff Kirsher
2020-05-21 7:27 ` [net-next 05/15] e1000: Do not perform reset in reset_task if we are already down Jeff Kirsher
2020-05-21 7:27 ` [net-next 06/15] igc: Remove obsolete circuit breaker registers Jeff Kirsher
2020-05-21 7:27 ` [net-next 07/15] igc: Remove header redirection register Jeff Kirsher
2020-05-21 7:27 ` [net-next 08/15] igc: Remove per queue good transmited counter register Jeff Kirsher
2020-05-21 7:27 ` [net-next 09/15] igc: Remove unused field from igc_nfc_filter Jeff Kirsher
2020-05-21 7:27 ` [net-next 10/15] igc: Get rid of igc_max_channels() Jeff Kirsher
2020-05-21 7:27 ` [net-next 11/15] igc: Cleanup _get|set_rxnfc ethtool ops Jeff Kirsher
2020-05-21 7:27 ` [net-next 12/15] igc: Early return in igc_get_ethtool_nfc_entry() Jeff Kirsher
2020-05-21 7:27 ` [net-next 13/15] igc: Add 'igc_ethtool_' prefix to functions in igc_ethtool.c Jeff Kirsher
2020-05-21 7:27 ` [net-next 14/15] igc: Align terms used in NFC support code Jeff Kirsher
2020-05-21 7:27 ` [net-next 15/15] igc: Change byte order in struct igc_nfc_filter Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200521092323.70b8c9b6@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=aaron.f.brown@intel.com \
--cc=andre.guedes@intel.com \
--cc=davem@davemloft.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).