From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 393F2C433DF for ; Fri, 22 May 2020 21:26:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 146F720723 for ; Fri, 22 May 2020 21:26:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731056AbgEVV0a (ORCPT ); Fri, 22 May 2020 17:26:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730976AbgEVV03 (ORCPT ); Fri, 22 May 2020 17:26:29 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF526C061A0E for ; Fri, 22 May 2020 14:26:29 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 49BF112725EDA; Fri, 22 May 2020 14:26:29 -0700 (PDT) Date: Fri, 22 May 2020 14:26:28 -0700 (PDT) Message-Id: <20200522.142628.1582912241162372403.davem@davemloft.net> To: claudiu.manoil@nxp.com Cc: netdev@vger.kernel.org, vladimir.oltean@nxp.com Subject: Re: [PATCH net] felix: Fix initialization of ioremap resources From: David Miller In-Reply-To: <1590137674-31727-1-git-send-email-claudiu.manoil@nxp.com> References: <1590137674-31727-1-git-send-email-claudiu.manoil@nxp.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 22 May 2020 14:26:29 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Claudiu Manoil Date: Fri, 22 May 2020 11:54:34 +0300 > The caller of devm_ioremap_resource(), either accidentally > or by wrong assumption, is writing back derived resource data > to global static resource initialization tables that should > have been constant. Meaning that after it computes the final > physical start address it saves the address for no reason > in the static tables. This doesn't affect the first driver > probing after reboot, but it breaks consecutive driver reloads > (i.e. driver unbind & bind) because the initialization tables > no longer have the correct initial values. So the next probe() > will map the device registers to wrong physical addresses, > causing ARM SError async exceptions. > This patch fixes all of the above. > > Fixes: 56051948773e ("net: dsa: ocelot: add driver for Felix switch family") > > Signed-off-by: Claudiu Manoil Applied and queued up for -stable, thanks.