From: David Miller <davem@davemloft.net>
To: rmk+kernel@armlinux.org.uk
Cc: maxime.chevallier@bootlin.com, kuba@kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net] net: mvpp2: fix RX hashing for non-10G ports
Date: Fri, 22 May 2020 15:32:36 -0700 (PDT) [thread overview]
Message-ID: <20200522.153236.595582419310375454.davem@davemloft.net> (raw)
In-Reply-To: <E1jbMrr-0008Jc-R7@rmk-PC.armlinux.org.uk>
From: Russell King <rmk+kernel@armlinux.org.uk>
Date: Wed, 20 May 2020 12:26:35 +0100
> When rxhash is enabled on any ethernet port except the first in each CP
> block, traffic flow is prevented. The analysis is below:
...
> So, this patch attempts to solve the issue by clearing the
> MVPP2_CLS_SWFWD_PCTRL_MASK() bit, allowing MVPP22_CLS_C2_ATTR0_QHIGH()
> from the classifier to define the queue-high field of the queue number.
>
> My testing seems to confirm my findings above - clearing this bit
> means that if I enable rxhash on eth2, the interface can then pass
> traffic, as we are now directing traffic to RX queue 1 rather than
> queue 33. Traffic still seems to work with rxhash off as well.
>
> Reported-by: Matteo Croce <mcroce@redhat.com>
> Tested-by: Matteo Croce <mcroce@redhat.com>
> Fixes: 895586d5dc32 ("net: mvpp2: cls: Use RSS contexts to handle RSS tables")
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Applied and queued up for -stable, thanks Russell.
prev parent reply other threads:[~2020-05-22 22:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 11:26 [PATCH net] net: mvpp2: fix RX hashing for non-10G ports Russell King
2020-05-22 22:32 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200522.153236.595582419310375454.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).