netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: valentin@longchamp.me
Cc: linuxppc-dev@lists.ozlabs.org, netdev@vger.kernel.org,
	kuba@kernel.org, hkallweit1@gmail.com, matteo.ghidoni@ch.abb.com
Subject: Re: [PATCH] net/ethernet/freescale: rework quiesce/activate for ucc_geth
Date: Fri, 22 May 2020 15:50:54 -0700 (PDT)	[thread overview]
Message-ID: <20200522.155054.352367636201826991.davem@davemloft.net> (raw)
In-Reply-To: <20200520155350.1372-1-valentin@longchamp.me>

From: Valentin Longchamp <valentin@longchamp.me>
Date: Wed, 20 May 2020 17:53:50 +0200

> ugeth_quiesce/activate are used to halt the controller when there is a
> link change that requires to reconfigure the mac.
> 
> The previous implementation called netif_device_detach(). This however
> causes the initial activation of the netdevice to fail precisely because
> it's detached. For details, see [1].
> 
> A possible workaround was the revert of commit
> net: linkwatch: add check for netdevice being present to linkwatch_do_dev
> However, the check introduced in the above commit is correct and shall be
> kept.
> 
> The netif_device_detach() is thus replaced with
> netif_tx_stop_all_queues() that prevents any tranmission. This allows to
> perform mac config change required by the link change, without detaching
> the corresponding netdevice and thus not preventing its initial
> activation.
> 
> [1] https://lists.openwall.net/netdev/2020/01/08/201
> 
> Signed-off-by: Valentin Longchamp <valentin@longchamp.me>
> Acked-by: Matteo Ghidoni <matteo.ghidoni@ch.abb.com>

Applied, thanks.

  reply	other threads:[~2020-05-22 22:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-20 15:53 [PATCH] net/ethernet/freescale: rework quiesce/activate for ucc_geth Valentin Longchamp
2020-05-22 22:50 ` David Miller [this message]
2020-05-26  5:16   ` Valentin Longchamp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200522.155054.352367636201826991.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=matteo.ghidoni@ch.abb.com \
    --cc=netdev@vger.kernel.org \
    --cc=valentin@longchamp.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).