From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Andrii Nakryiko <andriin@fb.com>
Cc: bpf@vger.kernel.org, netdev@vger.kernel.org, ast@fb.com,
daniel@iogearbox.net, andrii.nakryiko@gmail.com,
kernel-team@fb.com, "Paul E . McKenney" <paulmck@kernel.org>,
Jonathan Lemon <jonathan.lemon@gmail.com>
Subject: Re: [PATCH v2 bpf-next 5/7] selftests/bpf: add BPF ringbuf selftests
Date: Thu, 21 May 2020 18:20:34 -0700 [thread overview]
Message-ID: <20200522012034.sufpu7e62itcn2vg@ast-mbp.dhcp.thefacebook.com> (raw)
In-Reply-To: <20200517195727.279322-6-andriin@fb.com>
On Sun, May 17, 2020 at 12:57:25PM -0700, Andrii Nakryiko wrote:
> diff --git a/tools/testing/selftests/bpf/progs/test_ringbuf_multi.c b/tools/testing/selftests/bpf/progs/test_ringbuf_multi.c
> new file mode 100644
> index 000000000000..7eb85dd9cd66
> --- /dev/null
> +++ b/tools/testing/selftests/bpf/progs/test_ringbuf_multi.c
> @@ -0,0 +1,77 @@
> +// SPDX-License-Identifier: GPL-2.0
> +// Copyright (c) 2019 Facebook
oops ;)
> +
> +#include <linux/bpf.h>
> +#include <bpf/bpf_helpers.h>
> +
> +char _license[] SEC("license") = "GPL";
> +
> +struct sample {
> + int pid;
> + int seq;
> + long value;
> + char comm[16];
> +};
> +
> +struct ringbuf_map {
> + __uint(type, BPF_MAP_TYPE_RINGBUF);
> + __uint(max_entries, 1 << 12);
> +} ringbuf1 SEC(".maps"),
> + ringbuf2 SEC(".maps");
> +
> +struct {
> + __uint(type, BPF_MAP_TYPE_ARRAY_OF_MAPS);
> + __uint(max_entries, 4);
> + __type(key, int);
> + __array(values, struct ringbuf_map);
> +} ringbuf_arr SEC(".maps") = {
> + .values = {
> + [0] = &ringbuf1,
> + [2] = &ringbuf2,
> + },
> +};
the tests look great. Very easy to understand the usage model.
next prev parent reply other threads:[~2020-05-22 1:20 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-17 19:57 [PATCH v2 bpf-next 0/7] BPF ring buffer Andrii Nakryiko
2020-05-17 19:57 ` [PATCH v2 bpf-next 1/7] bpf: implement BPF ring buffer and verifier support for it Andrii Nakryiko
2020-05-19 12:57 ` kbuild test robot
2020-05-19 23:53 ` kbuild test robot
2020-05-22 0:25 ` Paul E. McKenney
2020-05-22 18:46 ` Andrii Nakryiko
2020-05-25 16:01 ` Paul E. McKenney
2020-05-25 18:45 ` Andrii Nakryiko
2020-05-22 1:07 ` Alexei Starovoitov
2020-05-22 18:48 ` Andrii Nakryiko
2020-05-25 20:34 ` Andrii Nakryiko
2020-05-17 19:57 ` [PATCH v2 bpf-next 2/7] tools/memory-model: add BPF ringbuf MPSC litmus tests Andrii Nakryiko
2020-05-22 0:34 ` Paul E. McKenney
2020-05-22 18:51 ` Andrii Nakryiko
2020-05-25 23:33 ` Andrii Nakryiko
2020-05-26 3:05 ` Paul E. McKenney
2020-05-17 19:57 ` [PATCH v2 bpf-next 3/7] bpf: track reference type in verifier Andrii Nakryiko
2020-05-22 1:13 ` Alexei Starovoitov
2020-05-22 18:53 ` Andrii Nakryiko
2020-05-17 19:57 ` [PATCH v2 bpf-next 4/7] libbpf: add BPF ring buffer support Andrii Nakryiko
2020-05-22 1:15 ` Alexei Starovoitov
2020-05-22 18:56 ` Andrii Nakryiko
2020-05-17 19:57 ` [PATCH v2 bpf-next 5/7] selftests/bpf: add BPF ringbuf selftests Andrii Nakryiko
2020-05-22 1:20 ` Alexei Starovoitov [this message]
2020-05-22 18:58 ` Andrii Nakryiko
2020-05-17 19:57 ` [PATCH v2 bpf-next 6/7] bpf: add BPF ringbuf and perf buffer benchmarks Andrii Nakryiko
2020-05-22 1:21 ` Alexei Starovoitov
2020-05-22 19:07 ` Andrii Nakryiko
2020-05-17 19:57 ` [PATCH v2 bpf-next 7/7] docs/bpf: add BPF ring buffer design notes Andrii Nakryiko
2020-05-22 1:23 ` Alexei Starovoitov
2020-05-22 19:08 ` Andrii Nakryiko
2020-05-25 9:59 ` Alban Crequy
2020-05-25 19:12 ` Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200522012034.sufpu7e62itcn2vg@ast-mbp.dhcp.thefacebook.com \
--to=alexei.starovoitov@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andriin@fb.com \
--cc=ast@fb.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=jonathan.lemon@gmail.com \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
--cc=paulmck@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).