* [PATCH] net/mlx4_core: fix a memory leak bug.
@ 2020-05-22 5:23 wu000273
2020-05-22 17:24 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: wu000273 @ 2020-05-22 5:23 UTC (permalink / raw)
To: tariqt; +Cc: davem, kuba, linux-rdma, linux-kernel, netdev, kjlu, wu000273
From: Qiushi Wu <wu000273@umn.edu>
In function mlx4_opreq_action(), pointer "mailbox" is not released,
when mlx4_cmd_box() return and error, causing a memory leak bug.
Fix this issue by going to "out" label, mlx4_free_cmd_mailbox() can
free this pointer.
Fixes: fe6f700d6cbb7 ("Respond to operation request by firmware")
Signed-off-by: Qiushi Wu <wu000273@umn.edu>
---
drivers/net/ethernet/mellanox/mlx4/fw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx4/fw.c b/drivers/net/ethernet/mellanox/mlx4/fw.c
index 6e501af0e532..f6ff9620a137 100644
--- a/drivers/net/ethernet/mellanox/mlx4/fw.c
+++ b/drivers/net/ethernet/mellanox/mlx4/fw.c
@@ -2734,7 +2734,7 @@ void mlx4_opreq_action(struct work_struct *work)
if (err) {
mlx4_err(dev, "Failed to retrieve required operation: %d\n",
err);
- return;
+ goto out;
}
MLX4_GET(modifier, outbox, GET_OP_REQ_MODIFIER_OFFSET);
MLX4_GET(token, outbox, GET_OP_REQ_TOKEN_OFFSET);
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net/mlx4_core: fix a memory leak bug.
2020-05-22 5:23 [PATCH] net/mlx4_core: fix a memory leak bug wu000273
@ 2020-05-22 17:24 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2020-05-22 17:24 UTC (permalink / raw)
To: wu000273; +Cc: tariqt, davem, linux-rdma, linux-kernel, netdev, kjlu
On Fri, 22 May 2020 00:23:48 -0500 wu000273@umn.edu wrote:
> From: Qiushi Wu <wu000273@umn.edu>
>
> In function mlx4_opreq_action(), pointer "mailbox" is not released,
> when mlx4_cmd_box() return and error, causing a memory leak bug.
> Fix this issue by going to "out" label, mlx4_free_cmd_mailbox() can
> free this pointer.
>
> Fixes: fe6f700d6cbb7 ("Respond to operation request by firmware")
> Signed-off-by: Qiushi Wu <wu000273@umn.edu>
Fixes tag: Fixes: fe6f700d6cbb7 ("Respond to operation request by firmware")
Has these problem(s):
- Subject does not match target commit subject
Just use
git log -1 --format='Fixes: %h ("%s")'
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-22 17:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-22 5:23 [PATCH] net/mlx4_core: fix a memory leak bug wu000273
2020-05-22 17:24 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).