From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71CA5C433DF for ; Fri, 22 May 2020 17:59:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 37BD4206D5 for ; Fri, 22 May 2020 17:59:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590170340; bh=EVdbRbXJ1zmCu+CbpWNQp6WFx/2esvUH/DkQOxAnqqs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=wmMHf/RJ/hBoscH3KGMM1q+ierCKJq8uGjivlQN+et+iyuYsXgz2jDFE0j3KuLjIs luOf58K+zo+B/8ztc3dl0rYBDegv2VYhcZ8XkLvelw5S1/cZaGZGstg2UD0ndplKQa 6JnN3wY6hm8aY9QBYz1zxvoUFr9H6oiT8qsY+b+8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730817AbgEVR67 (ORCPT ); Fri, 22 May 2020 13:58:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:58694 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730750AbgEVR67 (ORCPT ); Fri, 22 May 2020 13:58:59 -0400 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AB5CC206D5; Fri, 22 May 2020 17:58:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590170338; bh=EVdbRbXJ1zmCu+CbpWNQp6WFx/2esvUH/DkQOxAnqqs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=zSZpA4YlG5KXRM3JsB1sVntmZaoVUIhnzsw3nfN1Tg10b+zjSgH67h/4LCX3+7y0M Wn+gKOIOTSBPV0xFVoudWKhvx9DS3fELMXubbqYlv4xV7dQJO14Wz0REQAYQdcTSFX au6uqKtRLDCPvwZEduKs48OkWnszfS2X76t90neM= Date: Fri, 22 May 2020 10:58:57 -0700 From: Jakub Kicinski To: Igor Russkikh , Mark Starovoytov Cc: , "David S . Miller" Subject: Re: [PATCH v2 net-next 00/12] net: atlantic: QoS implementation Message-ID: <20200522105857.759e7589@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20200522081948.167-1-irusskikh@marvell.com> References: <20200522081948.167-1-irusskikh@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 22 May 2020 11:19:36 +0300 Igor Russkikh wrote: > This patch series adds support for mqprio rate limiters and multi-TC: > * max_rate is supported on both A1 and A2; > * min_rate is supported on A2 only; > > This is a joint work of Mark and Dmitry. > > To implement this feature, a couple of rearrangements and code > improvements were done, in areas of TC/ring management, allocation > control, etc. > > One of the problems we faced is conflicting ptp functionality, which > consumes a whole traffic class due to hardware limitations. > Patches below have a more detailed description on how PTP and multi-TC > co-exist right now. > > v2: > * accommodated review comments (-Wmissing-prototypes and > -Wunused-but-set-variable findings); > * added user notification in case of conflicting multi-TC<->PTP > configuration; > * added automatic PTP disabling, if a conflicting configuration is > detected; > * removed module param, which was used for PTP disabling in v1; > > v1: https://patchwork.ozlabs.org/cover/1294380/ Acked-by: Jakub Kicinski