From: David Miller <davem@davemloft.net>
To: michael@walle.cc
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
andrew@lunn.ch, f.fainelli@gmail.com, hkallweit1@gmail.com,
linux@armlinux.org.uk, kuba@kernel.org, ujhelyi.m@gmail.com
Subject: Re: [PATCH net-next] net: phy: at803x: fix PHY ID masks
Date: Sat, 23 May 2020 16:26:12 -0700 (PDT) [thread overview]
Message-ID: <20200523.162612.1919894290900733612.davem@davemloft.net> (raw)
In-Reply-To: <20200522095331.21448-1-michael@walle.cc>
From: Michael Walle <michael@walle.cc>
Date: Fri, 22 May 2020 11:53:31 +0200
> Ever since its first commit 0ca7111a38f05 ("phy: add AT803x driver") the
> PHY ID mask was set to 0xffffffef. It is unclear to me why this mask was
> chosen in the first place. Both the AR8031/AR8033 and the AR8035
> datasheets mention it is always the given value:
> - for AR8031/AR8033 its 0x004d/0xd074
> - for AR8035 its 0x004d/0xd072
>
> Unfortunately, I don't have a datasheet for the AR8030. Therefore, we
> leave its PHY ID mask untouched. For the PHYs mentioned before use the
> handy PHY_ID_MATCH_EXACT() macro.
>
> I've tried to contact the author of the initial commit, but received no
> answer so far.
>
> Cc: Matus Ujhelyi <ujhelyi.m@gmail.com>
> Signed-off-by: Michael Walle <michael@walle.cc>
Applied, thank you.
prev parent reply other threads:[~2020-05-23 23:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 9:53 [PATCH net-next] net: phy: at803x: fix PHY ID masks Michael Walle
2020-05-23 23:26 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200523.162612.1919894290900733612.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=michael@walle.cc \
--cc=netdev@vger.kernel.org \
--cc=ujhelyi.m@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).