From: David Miller <davem@davemloft.net>
To: leoyu@nvidia.com
Cc: peppe.cavallaro@st.com, alexandre.torgue@st.com,
joabreu@synopsys.com, kuba@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: stmmac: don't attach interface until resume finishes
Date: Sat, 23 May 2020 16:30:55 -0700 (PDT) [thread overview]
Message-ID: <20200523.163055.1502317714947171444.davem@davemloft.net> (raw)
In-Reply-To: <1590161383-8141-1-git-send-email-leoyu@nvidia.com>
From: Leon Yu <leoyu@nvidia.com>
Date: Fri, 22 May 2020 23:29:43 +0800
> Commit 14b41a2959fb ("net: stmmac: Delete txtimer in suspend") was the
> first attempt to fix a race between mod_timer() and setup_timer()
> during stmmac_resume(). However the issue still exists as the commit
> only addressed half of the issue.
>
> Same race can still happen as stmmac_resume() re-attaches interface
> way too early - even before hardware is fully initialized. Worse,
> doing so allows network traffic to restart and stmmac_tx_timer_arm()
> being called in the middle of stmmac_resume(), which re-init tx timers
> in stmmac_init_coalesce(). timer_list will be corrupted and system
> crashes as a result of race between mod_timer() and setup_timer().
>
> systemd--1995 2.... 552950018us : stmmac_suspend: 4994
> ksoftirq-9 0..s2 553123133us : stmmac_tx_timer_arm: 2276
> systemd--1995 0.... 553127896us : stmmac_resume: 5101
> systemd--320 7...2 553132752us : stmmac_tx_timer_arm: 2276
> (sd-exec-1999 5...2 553135204us : stmmac_tx_timer_arm: 2276
> ---------------------------------
> pc : run_timer_softirq+0x468/0x5e0
> lr : run_timer_softirq+0x570/0x5e0
> Call trace:
> run_timer_softirq+0x468/0x5e0
> __do_softirq+0x124/0x398
> irq_exit+0xd8/0xe0
> __handle_domain_irq+0x6c/0xc0
> gic_handle_irq+0x60/0xb0
> el1_irq+0xb8/0x180
> arch_cpu_idle+0x38/0x230
> default_idle_call+0x24/0x3c
> do_idle+0x1e0/0x2b8
> cpu_startup_entry+0x28/0x48
> secondary_start_kernel+0x1b4/0x208
>
> Fix this by deferring netif_device_attach() to the end of
> stmmac_resume().
>
> Signed-off-by: Leon Yu <leoyu@nvidia.com>
Applied, thank you.
next prev parent reply other threads:[~2020-05-23 23:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 15:29 [PATCH] net: stmmac: don't attach interface until resume finishes Leon Yu
2020-05-23 23:30 ` David Miller [this message]
2021-09-28 7:49 backport commit ("31096c3e8b11 net: stmmac: don't attach interface until resume finishes") to linux-5.4-stable Greg KH
2021-09-28 8:36 ` [PATCH] net: stmmac: don't attach interface until resume finishes Macpaul Lin
2021-10-04 10:11 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200523.163055.1502317714947171444.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexandre.torgue@st.com \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=leoyu@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).