From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18BCEC433E0 for ; Sat, 23 May 2020 23:57:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EB8A7207FB for ; Sat, 23 May 2020 23:57:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388199AbgEWX5U (ORCPT ); Sat, 23 May 2020 19:57:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54792 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388106AbgEWX5T (ORCPT ); Sat, 23 May 2020 19:57:19 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CEBD3C061A0E for ; Sat, 23 May 2020 16:57:19 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 9054C12873760; Sat, 23 May 2020 16:57:19 -0700 (PDT) Date: Sat, 23 May 2020 16:57:18 -0700 (PDT) Message-Id: <20200523.165718.1124885913264494628.davem@davemloft.net> To: hkallweit1@gmail.com Cc: kuba@kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH net-next] ethtool: propagate get_coalesce return value From: David Miller In-Reply-To: <1f4f887a-4339-1ece-b2aa-c9712e54bce3@gmail.com> References: <1f4f887a-4339-1ece-b2aa-c9712e54bce3@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 23 May 2020 16:57:19 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Heiner Kallweit Date: Sat, 23 May 2020 17:40:25 +0200 > get_coalesce returns 0 or ERRNO, but the return value isn't checked. > The returned coalesce data may be invalid if an ERRNO is set, > therefore better check and propagate the return value. > > Signed-off-by: Heiner Kallweit Applied, thanks Heiner.